bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if
Now when we change the attributes of bridge or br_port by netlink, a relevant netlink notification will be sent, but if we change them by ioctl or sysfs, no notification will be sent. We should ensure that whenever those attributes change internally or from sysfs/ioctl, that a netlink notification is sent out to listeners. Also, NetworkManager will use this in the future to listen for out-of-band bridge master attribute updates and incorporate them into the runtime configuration. This patch is used for br_sysfs_if, and we also move br_ifinfo_notify out of store_flag. Signed-off-by: Xin Long <lucien.xin@gmail.com> Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
047831a9b9
commit
bdaf0d5d98
|
@ -61,7 +61,6 @@ static int store_flag(struct net_bridge_port *p, unsigned long v,
|
|||
if (flags != p->flags) {
|
||||
p->flags = flags;
|
||||
br_port_flags_change(p, mask);
|
||||
br_ifinfo_notify(RTM_NEWLINK, p);
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
@ -253,8 +252,10 @@ static ssize_t brport_store(struct kobject *kobj,
|
|||
spin_lock_bh(&p->br->lock);
|
||||
ret = brport_attr->store(p, val);
|
||||
spin_unlock_bh(&p->br->lock);
|
||||
if (ret == 0)
|
||||
if (!ret) {
|
||||
br_ifinfo_notify(RTM_NEWLINK, p);
|
||||
ret = count;
|
||||
}
|
||||
}
|
||||
rtnl_unlock();
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue