redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

of: Minor simplification for the of_parse_phandles_with_args()

Browse source 
By using 'list++' in the beginning we can simplify the code a
little bit.

Suggested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Anton Vorontsov 2008-12-05 08:15:39 +00:00 committed by Paul Mackerras
parent c280266a32
commit c1bb7c6d04
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/of/base.c
View file

@ -547,14 +547,12 @@ int of_parse_phandles_with_args(struct device_node *np, const char *list_name,
const u32 *cells;
const phandle *phandle;
phandle = list;
args = list + 1;
phandle = list++;
args = list;
/* one cell hole in the list = <>; */
if (!*phandle) {
list++;
if (!*phandle)
goto next;
}
node = of_find_node_by_phandle(*phandle);
if (!node) {
@ -570,8 +568,7 @@ int of_parse_phandles_with_args(struct device_node *np, const char *list_name,
goto err1;
}
/* Next phandle is at offset of one phandle cell + #cells */
list += 1 + *cells;
list += *cells;
if (list > list_end) {
pr_debug("%s: insufficient arguments length\n",
np->full_name);