cpupower: Correct return type of cpu_power_is_cpu_online() in cpufreq-set
When converting to a shared library inac5a181d06
("cpupower: Add cpuidle parts into library"), cpu_freq_cpu_exists() was converted to cpupower_is_cpu_online(). cpu_req_cpu_exists() returned 0 on success and -ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success. Check for the correct return value in cpufreq-set. Link: https://bugzilla.redhat.com/show_bug.cgi?id=1374212 Fixes:ac5a181d06
(cpupower: Add cpuidle parts into library) Reported-by: Julian Seward <jseward@acm.org> Signed-off-by: Laura Abbott <labbott@redhat.com> Acked-by: Thomas Renninger <trenn@suse.com> Cc: 4.7+ <stable@vger.kernel.org> # 4.7+ Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
parent
a909d3e636
commit
c25badc9ce
|
@ -296,7 +296,7 @@ int cmd_freq_set(int argc, char **argv)
|
||||||
struct cpufreq_affected_cpus *cpus;
|
struct cpufreq_affected_cpus *cpus;
|
||||||
|
|
||||||
if (!bitmask_isbitset(cpus_chosen, cpu) ||
|
if (!bitmask_isbitset(cpus_chosen, cpu) ||
|
||||||
cpupower_is_cpu_online(cpu))
|
cpupower_is_cpu_online(cpu) != 1)
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
cpus = cpufreq_get_related_cpus(cpu);
|
cpus = cpufreq_get_related_cpus(cpu);
|
||||||
|
@ -316,10 +316,7 @@ int cmd_freq_set(int argc, char **argv)
|
||||||
cpu <= bitmask_last(cpus_chosen); cpu++) {
|
cpu <= bitmask_last(cpus_chosen); cpu++) {
|
||||||
|
|
||||||
if (!bitmask_isbitset(cpus_chosen, cpu) ||
|
if (!bitmask_isbitset(cpus_chosen, cpu) ||
|
||||||
cpupower_is_cpu_online(cpu))
|
cpupower_is_cpu_online(cpu) != 1)
|
||||||
continue;
|
|
||||||
|
|
||||||
if (cpupower_is_cpu_online(cpu) != 1)
|
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
printf(_("Setting cpu: %d\n"), cpu);
|
printf(_("Setting cpu: %d\n"), cpu);
|
||||||
|
|
Loading…
Reference in a new issue