net: don't call strlen on non-terminated string in dev_set_alias()
KMSAN reported a use of uninitialized memory in dev_set_alias(), which was caused by calling strlcpy() (which in turn called strlen()) on the user-supplied non-terminated string. Signed-off-by: Alexander Potapenko <glider@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
b29794ec95
commit
c28294b941
|
@ -1253,8 +1253,9 @@ int dev_set_alias(struct net_device *dev, const char *alias, size_t len)
|
||||||
if (!new_ifalias)
|
if (!new_ifalias)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
dev->ifalias = new_ifalias;
|
dev->ifalias = new_ifalias;
|
||||||
|
memcpy(dev->ifalias, alias, len);
|
||||||
|
dev->ifalias[len] = 0;
|
||||||
|
|
||||||
strlcpy(dev->ifalias, alias, len+1);
|
|
||||||
return len;
|
return len;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue