sctp: Fix a big endian bug in sctp_diag_dump()
The sctp_for_each_transport() function takes an pointer to int. The
cb->args[] array holds longs so it's only using the high 32 bits. It
works on little endian system but will break on big endian 64 bit
machines.
Fixes: d25adbeb0c
("sctp: fix an use-after-free issue in sctp_sock_dump")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
zero-colors
parent
20c62c797e
commit
c2cc187e53
|
@ -463,6 +463,7 @@ static void sctp_diag_dump(struct sk_buff *skb, struct netlink_callback *cb,
|
||||||
.r = r,
|
.r = r,
|
||||||
.net_admin = netlink_net_capable(cb->skb, CAP_NET_ADMIN),
|
.net_admin = netlink_net_capable(cb->skb, CAP_NET_ADMIN),
|
||||||
};
|
};
|
||||||
|
int pos = cb->args[2];
|
||||||
|
|
||||||
/* eps hashtable dumps
|
/* eps hashtable dumps
|
||||||
* args:
|
* args:
|
||||||
|
@ -493,7 +494,8 @@ skip:
|
||||||
goto done;
|
goto done;
|
||||||
|
|
||||||
sctp_for_each_transport(sctp_sock_filter, sctp_sock_dump,
|
sctp_for_each_transport(sctp_sock_filter, sctp_sock_dump,
|
||||||
net, (int *)&cb->args[2], &commp);
|
net, &pos, &commp);
|
||||||
|
cb->args[2] = pos;
|
||||||
|
|
||||||
done:
|
done:
|
||||||
cb->args[1] = cb->args[4];
|
cb->args[1] = cb->args[4];
|
||||||
|
|
Loading…
Reference in New Issue