redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

net/act_pedit: fix an error code 

I'm reviewing static checker warnings where we do ERR_PTR(0), which is
the same as NULL.  I'm pretty sure we intended to return ERR_PTR(-EINVAL)
here.  Sometimes these bugs lead to a NULL dereference but I don't
immediately see that problem here.

Fixes: 71d0ed7079 ("net/act_pedit: Support using offset relative to the conventional network headers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Amir Vadai <amir@vadai.me>
Signed-off-by: David S. Miller <davem@davemloft.net>
zero-colors
Dan Carpenter 2017-06-14 13:29:31 +03:00 committed by David S. Miller
parent db46a0e1be
commit c4f65b09b4
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/sched/act_pedit.c
View File

@ -94,8 +94,10 @@ static struct tcf_pedit_key_ex *tcf_pedit_keys_ex_parse(struct nlattr *nla,
k++;
}
if (n)
if (n) {
err = -EINVAL;
goto err_out;
}
return keys_ex;