USB: appledisplay: refactor endpoint retrieval
Use the new endpoint helpers to lookup the required interrupt-in endpoint. Note that the default retval was never used. Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
e53e0342da
commit
c77b8855c6
|
@ -212,28 +212,21 @@ static int appledisplay_probe(struct usb_interface *iface,
|
|||
struct backlight_properties props;
|
||||
struct appledisplay *pdata;
|
||||
struct usb_device *udev = interface_to_usbdev(iface);
|
||||
struct usb_host_interface *iface_desc;
|
||||
struct usb_endpoint_descriptor *endpoint;
|
||||
int int_in_endpointAddr = 0;
|
||||
int i, retval = -ENOMEM, brightness;
|
||||
int retval, brightness;
|
||||
char bl_name[20];
|
||||
|
||||
/* set up the endpoint information */
|
||||
/* use only the first interrupt-in endpoint */
|
||||
iface_desc = iface->cur_altsetting;
|
||||
for (i = 0; i < iface_desc->desc.bNumEndpoints; i++) {
|
||||
endpoint = &iface_desc->endpoint[i].desc;
|
||||
if (!int_in_endpointAddr && usb_endpoint_is_int_in(endpoint)) {
|
||||
/* we found an interrupt in endpoint */
|
||||
int_in_endpointAddr = endpoint->bEndpointAddress;
|
||||
break;
|
||||
}
|
||||
}
|
||||
if (!int_in_endpointAddr) {
|
||||
retval = usb_find_int_in_endpoint(iface->cur_altsetting, &endpoint);
|
||||
if (retval) {
|
||||
dev_err(&iface->dev, "Could not find int-in endpoint\n");
|
||||
return -EIO;
|
||||
return retval;
|
||||
}
|
||||
|
||||
int_in_endpointAddr = endpoint->bEndpointAddress;
|
||||
|
||||
/* allocate memory for our device state and initialize it */
|
||||
pdata = kzalloc(sizeof(struct appledisplay), GFP_KERNEL);
|
||||
if (!pdata) {
|
||||
|
|
Loading…
Reference in a new issue