tracing: Fix return while holding a lock in register_tracer()
commitd39cdd2036
("tracing: Make tracer_flags use the right set_flag callback") introduces a potential mutex deadlock issue, as it forgets to free the mutex when allocaing the tracer_flags gets fail. The issue was found by Dan Carpenter through Smatch static code check tool. Link: http://lkml.kernel.org/r/1457958941-30265-1-git-send-email-chuhu@redhat.com Fixes:d39cdd2036
("tracing: Make tracer_flags use the right set_flag callback") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Chunyu Hu <chuhu@redhat.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This commit is contained in:
parent
6363c6b599
commit
c8ca003b2f
|
@ -1256,8 +1256,10 @@ int __init register_tracer(struct tracer *type)
|
|||
if (!type->flags) {
|
||||
/*allocate a dummy tracer_flags*/
|
||||
type->flags = kmalloc(sizeof(*type->flags), GFP_KERNEL);
|
||||
if (!type->flags)
|
||||
return -ENOMEM;
|
||||
if (!type->flags) {
|
||||
ret = -ENOMEM;
|
||||
goto out;
|
||||
}
|
||||
type->flags->val = 0;
|
||||
type->flags->opts = dummy_tracer_opt;
|
||||
} else
|
||||
|
|
Loading…
Reference in a new issue