redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

proc: change first_tid() to use while_each_thread() rather than next_thread()

Browse source 
Rerwrite the main loop to use while_each_thread() instead of
next_thread().  We are going to fix or replace while_each_thread(),
next_thread() should be avoided whenever possible.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Sameer Nanda <snanda@chromium.org>
Cc: Sergey Dyasly <dserrg@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Oleg Nesterov 2014-01-23 15:55:38 -08:00 committed by Linus Torvalds
parent 940fe4793a
commit c986c14a6a
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
fs/proc/base.c
View file

@ -3106,23 +3106,23 @@ static struct task_struct *first_tid(struct task_struct *leader,
} }
/* If nr exceeds the number of threads there is nothing todo */ /* If nr exceeds the number of threads there is nothing todo */
pos = NULL;
if (nr && nr >= get_nr_threads(leader)) if (nr && nr >= get_nr_threads(leader))
goto out; goto fail;
/* It could be unhashed before we take rcu lock */ /* It could be unhashed before we take rcu lock */
if (!pid_alive(leader)) if (!pid_alive(leader))
goto out; goto fail;
/* If we haven't found our starting place yet start /* If we haven't found our starting place yet start
* with the leader and walk nr threads forward. * with the leader and walk nr threads forward.
*/ */
for (pos = leader; nr > 0; --nr) { pos = leader;
pos = next_thread(pos); do {
if (pos == leader) { if (nr-- <= 0)
pos = NULL; goto found;
goto out; } while_each_thread(leader, pos);
} fail:
} pos = NULL;
goto out;
found: found:
get_task_struct(pos); get_task_struct(pos);
out: out: