redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

sunrpc: do not pin sunrpc module in the memory 

Basically, try_module_get here are pretty useless. Any other module using
this API will pin sunrpc in memory due using exported symbols.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
wifi-calibration
Denis V. Lunev 2008-07-31 09:53:56 +04:00 committed by Trond Myklebust
parent fd08d7e9d1
commit c9f6cde6e2
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
net/sunrpc/xprt.c
View File

@ -108,13 +108,10 @@ int xprt_register_transport(struct xprt_class *transport)
goto out; goto out;
} }
result = -EINVAL; list_add_tail(&transport->list, &xprt_list);
if (try_module_get(THIS_MODULE)) { printk(KERN_INFO "RPC: Registered %s transport module.\n",
list_add_tail(&transport->list, &xprt_list); transport->name);
printk(KERN_INFO "RPC: Registered %s transport module.\n", result = 0;
transport->name);
result = 0;
}
out: out:
spin_unlock(&xprt_list_lock); spin_unlock(&xprt_list_lock);
@ -143,7 +140,6 @@ int xprt_unregister_transport(struct xprt_class *transport)
"RPC: Unregistered %s transport module.\n", "RPC: Unregistered %s transport module.\n",
transport->name); transport->name);
list_del_init(&transport->list); list_del_init(&transport->list);
module_put(THIS_MODULE);
goto out; goto out;
} }
} }