redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

selinux: Adjust four checks for null pointers 

The script "checkpatch.pl" pointed information out like the following.

Comparison to NULL could be written !…

Thus fix affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Paul Moore <paul@paul-moore.com>
zero-colors
Markus Elfring 2017-01-14 12:36:59 +01:00 committed by Paul Moore
parent 2f00e680fe
commit cb8d21e364
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
security/selinux/ss/hashtab.c
View File

@ -17,7 +17,7 @@ struct hashtab *hashtab_create(u32 (*hash_value)(struct hashtab *h, const void *
u32 i;
p = kzalloc(sizeof(*p), GFP_KERNEL);
if (p == NULL)
if (!p)
return p;
p->size = size;
@ -25,7 +25,7 @@ struct hashtab *hashtab_create(u32 (*hash_value)(struct hashtab *h, const void *
p->hash_value = hash_value;
p->keycmp = keycmp;
p->htable = kmalloc_array(size, sizeof(*p->htable), GFP_KERNEL);
if (p->htable == NULL) {
if (!p->htable) {
kfree(p);
return NULL;
}
@ -58,7 +58,7 @@ int hashtab_insert(struct hashtab *h, void *key, void *datum)
return -EEXIST;
newnode = kzalloc(sizeof(*newnode), GFP_KERNEL);
if (newnode == NULL)
if (!newnode)
return -ENOMEM;
newnode->key = key;
newnode->datum = datum;
@ -87,7 +87,7 @@ void *hashtab_search(struct hashtab *h, const void *key)
while (cur && h->keycmp(h, key, cur->key) > 0)
cur = cur->next;
if (cur == NULL || (h->keycmp(h, key, cur->key) != 0))
if (!cur || (h->keycmp(h, key, cur->key) != 0))
return NULL;
return cur->datum;