redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

drivers/video/sm501fb.c: Convert release_resource to release_mem_region

Browse source 
Request_mem_region should be used with release_mem_region, not
release_resource.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@s exists@
expression e1,e2,e3,e4,e;
@@

*e4 = request_mem_region(e1,e2,e3)
... when != e4 = e
*release_resource(e4);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
This commit is contained in:
Julia Lawall 2011-04-22 20:11:22 +00:00 committed by Paul Mundt
parent 683e7cdc20
commit d2f6b7f7aa
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
drivers/video/sm501fb.c
View file

@ -1625,22 +1625,22 @@ static int sm501fb_start(struct sm501fb_info *info,
return 0; /* everything is setup */
err_mem_res:
release_resource(info->fbmem_res);
kfree(info->fbmem_res);
release_mem_region(info->fbmem_res->start,
resource_size(info->fbmem_res));
err_regs2d_map:
iounmap(info->regs2d);
err_regs2d_res:
release_resource(info->regs2d_res);
kfree(info->regs2d_res);
release_mem_region(info->regs2d_res->start,
resource_size(info->regs2d_res));
err_regs_map:
iounmap(info->regs);
err_regs_res:
release_resource(info->regs_res);
kfree(info->regs_res);
release_mem_region(info->regs_res->start,
resource_size(info->regs_res));
err_release:
return ret;
@ -1652,16 +1652,16 @@ static void sm501fb_stop(struct sm501fb_info *info)
sm501_unit_power(info->dev->parent, SM501_GATE_DISPLAY, 0);
iounmap(info->fbmem);
release_resource(info->fbmem_res);
kfree(info->fbmem_res);
release_mem_region(info->fbmem_res->start,
resource_size(info->fbmem_res));
iounmap(info->regs2d);
release_resource(info->regs2d_res);
kfree(info->regs2d_res);
release_mem_region(info->regs2d_res->start,
resource_size(info->regs2d_res));
iounmap(info->regs);
release_resource(info->regs_res);
kfree(info->regs_res);
release_mem_region(info->regs_res->start,
resource_size(info->regs_res));
}
static int sm501fb_init_fb(struct fb_info *fb,