redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

bio: get rid of bio_vec clearing 

We don't need to clear the memory used for adding bio_vec entries,
since nobody should be looking at members unitialized. Any valid
use should be below bio->bi_vcnt, and that members up until that count
must be valid since they were added through bio_add_page().

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
wifi-calibration
Jens Axboe 2008-12-23 12:46:21 +01:00
parent f735b5eeb9
commit d3f761104b
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/bio.c
View File

@ -180,7 +180,7 @@ struct bio_vec *bvec_alloc_bs(gfp_t gfp_mask, int nr, unsigned long *idx,
* kzalloc() for the exact number of vecs right away. * kzalloc() for the exact number of vecs right away.
*/ */
if (!bs) if (!bs)
bvl = kzalloc(nr * sizeof(struct bio_vec), gfp_mask); bvl = kmalloc(nr * sizeof(struct bio_vec), gfp_mask);
/* /*
* see comment near bvec_array define! * see comment near bvec_array define!
@ -237,9 +237,6 @@ fallback:
} }
} }
if (bvl)
memset(bvl, 0, bvec_nr_vecs(*idx) * sizeof(struct bio_vec));
return bvl; return bvl;
} }
@ -325,7 +322,6 @@ struct bio *bio_alloc_bioset(gfp_t gfp_mask, int nr_iovecs, struct bio_set *bs)
idx = 0; idx = 0;
bvl = bio->bi_inline_vecs; bvl = bio->bi_inline_vecs;
nr_iovecs = BIO_INLINE_VECS; nr_iovecs = BIO_INLINE_VECS;
memset(bvl, 0, BIO_INLINE_VECS * sizeof(*bvl));
} else { } else {
bvl = bvec_alloc_bs(gfp_mask, nr_iovecs, &idx, bvl = bvec_alloc_bs(gfp_mask, nr_iovecs, &idx,
bs); bs);