redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

m32r: remove redundant tests on unsigned

Browse source 
`off' and `max_cpus' are unsigned.  When negative they are wrapped and
caught by the other test.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Hirokazu Takata <takata@linux-m32r.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Roel Kluin 2009-09-21 17:04:03 -07:00 committed by Linus Torvalds
parent 1f69366545
commit d5a6d17395
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
arch/m32r/kernel/ptrace.c
View file

@ -77,7 +77,7 @@ static int ptrace_read_user(struct task_struct *tsk, unsigned long off,
struct user * dummy = NULL;
#endif
if ((off & 3) || (off < 0) || (off > sizeof(struct user) - 3))
if ((off & 3) || off > sizeof(struct user) - 3)
return -EIO;
off >>= 2;
@ -139,8 +139,7 @@ static int ptrace_write_user(struct task_struct *tsk, unsigned long off,
struct user * dummy = NULL;
#endif
if ((off & 3) || off < 0 ||
off > sizeof(struct user) - 3)
if ((off & 3) || off > sizeof(struct user) - 3)
return -EIO;
off >>= 2;

2
arch/m32r/kernel/smpboot.c
View file

@ -213,7 +213,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
if (!physid_isset(phys_id, phys_cpu_present_map))
continue;
if ((max_cpus >= 0) && (max_cpus <= cpucount + 1))
if (max_cpus <= cpucount + 1)
continue;
do_boot_cpu(phys_id);