redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

fs/xfs: Correct NULL test

Browse source 
Test the value that was just allocated rather than the previously tested one.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
expression *x;
expression e;
identifier l;
@@

if (x == NULL || ...) {
    ... when forall
    return ...; }
... when != goto l;
    when != x = e
    when != &x
*x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
This commit is contained in:
Julia Lawall 2010-02-06 08:45:15 +00:00 committed by Alex Elder
parent 180040b89e
commit d67b1b0325
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
fs/xfs/quota/xfs_qm.c
View file

@ -123,7 +123,7 @@ xfs_Gqm_init(void)
goto out;
gdqhash = kmem_zalloc_large(hsize);
if (!udqhash)
if (!gdqhash)
goto out_free_udqhash;
hsize /= sizeof(xfs_dqhash_t);