ALSA: hda - use WARN_ON_ONCE() for zero-division detection
Replace the zero-division warning message with WARN_ON_ONCE() per the advice by Linus. This shouldn't happen, but if it happens, it's possible that the bug happens often due to buggy IRQs. Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
parent
fed08d036f
commit
d6d8bf5493
|
@ -1893,12 +1893,9 @@ static int azx_position_ok(struct azx *chip, struct azx_dev *azx_dev)
|
||||||
|
|
||||||
if (!bdl_pos_adj[chip->dev_index])
|
if (!bdl_pos_adj[chip->dev_index])
|
||||||
return 1; /* no delayed ack */
|
return 1; /* no delayed ack */
|
||||||
if (azx_dev->period_bytes == 0) {
|
if (WARN_ONCE(!azx_dev->period_bytes,
|
||||||
printk(KERN_WARNING
|
"hda-intel: zero azx_dev->period_bytes"))
|
||||||
"hda-intel: Divide by zero was avoided "
|
return 0; /* this shouldn't happen! */
|
||||||
"in azx_dev->period_bytes.\n");
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
if (pos % azx_dev->period_bytes > azx_dev->period_bytes / 2)
|
if (pos % azx_dev->period_bytes > azx_dev->period_bytes / 2)
|
||||||
return 0; /* NG - it's below the period boundary */
|
return 0; /* NG - it's below the period boundary */
|
||||||
return 1; /* OK, it's fine */
|
return 1; /* OK, it's fine */
|
||||||
|
|
Loading…
Reference in a new issue