redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

hwmon: Fix PCI device reference leak in quirk

Browse source 
Thankfully this only affects systems with one specific south bridge
and is most probably harmless unless the hwmon module is heavily
cycled.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Jean Delvare 2012-12-19 22:16:59 +01:00 committed by Jean Delvare
parent 752451f01c
commit d6dab7dd12
1 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
drivers/hwmon/hwmon.c
View file

@ -84,19 +84,21 @@ static void __init hwmon_pci_quirks(void)
/* Open access to 0x295-0x296 on MSI MS-7031 */ /* Open access to 0x295-0x296 on MSI MS-7031 */
sb = pci_get_device(PCI_VENDOR_ID_ATI, 0x436c, NULL); sb = pci_get_device(PCI_VENDOR_ID_ATI, 0x436c, NULL);
if (sb && if (sb) {
(sb->subsystem_vendor == 0x1462 && /* MSI */ if (sb->subsystem_vendor == 0x1462 && /* MSI */
sb->subsystem_device == 0x0031)) { /* MS-7031 */ sb->subsystem_device == 0x0031) { /* MS-7031 */
pci_read_config_byte(sb, 0x48, &enable);
pci_read_config_word(sb, 0x64, &base);
pci_read_config_byte(sb, 0x48, &enable); if (base == 0 && !(enable & BIT(2))) {
pci_read_config_word(sb, 0x64, &base); dev_info(&sb->dev,
"Opening wide generic port at 0x295\n");
if (base == 0 && !(enable & BIT(2))) { pci_write_config_word(sb, 0x64, 0x295);
dev_info(&sb->dev, pci_write_config_byte(sb, 0x48,
"Opening wide generic port at 0x295\n"); enable | BIT(2));
pci_write_config_word(sb, 0x64, 0x295); }
pci_write_config_byte(sb, 0x48, enable | BIT(2));
} }
pci_dev_put(sb);
} }
#endif #endif
} }