[S390] arch/s390/kernel: Add missing unlock
In the default case the lock is not unlocked. The return is converted to a goto, to share the unlock at the end of the function. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ expression E1; identifier f; @@ f (...) { <+... * spin_lock_irq (E1,...); ... when != E1 * return ...; ...+> } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
parent
d620a7cf05
commit
d7015c120e
|
@ -165,10 +165,11 @@ static void tl_to_cores(struct tl_info *info)
|
|||
default:
|
||||
clear_cores();
|
||||
machine_has_topology = 0;
|
||||
return;
|
||||
goto out;
|
||||
}
|
||||
tle = next_tle(tle);
|
||||
}
|
||||
out:
|
||||
spin_unlock_irq(&topology_lock);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue