redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

video: of: display_timing: remove two unsafe error messages 

The error message would try to dereference the pointer that
just has been tested to be NULL. As those messages don't
really add any value without the info that the np could
provide, just remove them.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
wifi-calibration
Lucas Stach 2014-05-13 14:58:21 +02:00 committed by Tomi Valkeinen
parent 34bdb666f4
commit dc42715faf
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/video/of_display_timing.c
View File

@ -115,10 +115,8 @@ int of_get_display_timing(struct device_node *np, const char *name,
{
struct device_node *timing_np;
if (!np) {
pr_err("%s: no devicenode given\n", of_node_full_name(np));
if (!np)
return -EINVAL;
}
timing_np = of_get_child_by_name(np, name);
if (!timing_np) {
@ -142,10 +140,8 @@ struct display_timings *of_get_display_timings(struct device_node *np)
struct device_node *native_mode;
struct display_timings *disp;
if (!np) {
pr_err("%s: no device node given\n", of_node_full_name(np));
if (!np)
return NULL;
}
timings_np = of_get_child_by_name(np, "display-timings");
if (!timings_np) {