dmaengine: fix dependency chaining
In dmaengine we track the dependencies between the descriptors using the 'next' pointers of the structure. These pointers are set to NULL as soon as the corresponding descriptor has been submitted to the channel (in dma_run_dependencies()). But, the first 'next' in chain is still remaining set, regardless the fact, that tx->next has been already submitted. This may lead to multiple submissions of the same descriptor. This patch fixes this. Actually, some previous implementation of the xxx_run_dependencies() function already had this fix in place. The fdb..0eaf3 commit, beside the correct things, broke this. Cc: <stable@kernel.org> Signed-off-by: Yuri Tikhonov <yur@emcraft.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
parent
c59765042f
commit
dd59b8537f
|
@ -961,6 +961,8 @@ void dma_run_dependencies(struct dma_async_tx_descriptor *tx)
|
||||||
if (!dep)
|
if (!dep)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
|
/* we'll submit tx->next now, so clear the link */
|
||||||
|
tx->next = NULL;
|
||||||
chan = dep->chan;
|
chan = dep->chan;
|
||||||
|
|
||||||
/* keep submitting up until a channel switch is detected
|
/* keep submitting up until a channel switch is detected
|
||||||
|
|
Loading…
Reference in a new issue