redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

[PATCH] proc: Remove tasklist_lock from proc_pid_lookup() and proc_task_lookup()

Browse source 
Since we no longer need the tasklist_lock for get_task_struct the lookup
methods no longer need the tasklist_lock.

This just depends on my previous patch that makes get_task_struct() rcu
safe.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Eric W. Biederman 2006-06-26 00:25:51 -07:00 committed by Linus Torvalds
parent 454cc105ef
commit de7587343b
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
fs/proc/base.c
View file

@ -1940,11 +1940,11 @@ struct dentry *proc_pid_lookup(struct inode *dir, struct dentry * dentry, struct
if (tgid == ~0U) if (tgid == ~0U)
goto out; goto out;
read_lock(&tasklist_lock); rcu_read_lock();
task = find_task_by_pid(tgid); task = find_task_by_pid(tgid);
if (task) if (task)
get_task_struct(task); get_task_struct(task);
read_unlock(&tasklist_lock); rcu_read_unlock();
if (!task) if (!task)
goto out; goto out;
@ -1988,11 +1988,11 @@ static struct dentry *proc_task_lookup(struct inode *dir, struct dentry * dentry
if (tid == ~0U) if (tid == ~0U)
goto out; goto out;
read_lock(&tasklist_lock); rcu_read_lock();
task = find_task_by_pid(tid); task = find_task_by_pid(tid);
if (task) if (task)
get_task_struct(task); get_task_struct(task);
read_unlock(&tasklist_lock); rcu_read_unlock();
if (!task) if (!task)
goto out; goto out;
if (leader->tgid != task->tgid) if (leader->tgid != task->tgid)