redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

regulator: core: Return error in get optional stub

Browse source 
Drivers that call regulator_get_optional are tolerant to the absence of
that regulator.  By modifying the value returned from the stub function
to match that seen when a regulator isn't present, callers can wrap the
regulator logic with an IS_ERR based conditional even if they happen to
call regulator_is_supported_voltage.  This improves efficiency as well
as eliminates the possibility for a very subtle bug.

Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
Tim Kryger 2014-04-17 11:55:24 -07:00 committed by Mark Brown
parent c9eaa447e7
commit df7926fffa
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
include/linux/regulator/consumer.h
View file

@ -258,14 +258,14 @@ regulator_get_exclusive(struct device *dev, const char *id)
static inline struct regulator *__must_check static inline struct regulator *__must_check
regulator_get_optional(struct device *dev, const char *id) regulator_get_optional(struct device *dev, const char *id)
{ {
return NULL; return ERR_PTR(-ENODEV);
} }
static inline struct regulator *__must_check static inline struct regulator *__must_check
devm_regulator_get_optional(struct device *dev, const char *id) devm_regulator_get_optional(struct device *dev, const char *id)
{ {
return NULL; return ERR_PTR(-ENODEV);
} }
static inline void regulator_put(struct regulator *regulator) static inline void regulator_put(struct regulator *regulator)