redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

bonding: remove dev_base_lock use

Browse source 
bond_info_seq_start() uses a read_lock(&dev_base_lock) to make sure
device doesn’t disappear. Same goal can be achieved using RCU.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2010-10-29 01:52:46 +00:00 committed by David S. Miller
parent 840a185ddd
commit e4a7b93bd5
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/net/bonding/bond_main.c
View file

@ -3209,7 +3209,7 @@ out:
#ifdef CONFIG_PROC_FS
static void *bond_info_seq_start(struct seq_file *seq, loff_t *pos)
__acquires(&dev_base_lock)
__acquires(RCU)
__acquires(&bond->lock)
{
struct bonding *bond = seq->private;
@ -3218,7 +3218,7 @@ static void *bond_info_seq_start(struct seq_file *seq, loff_t *pos)
int i;
/* make sure the bond won't be taken away */
read_lock(&dev_base_lock);
rcu_read_lock();
read_lock(&bond->lock);
if (*pos == 0)
@ -3248,12 +3248,12 @@ static void *bond_info_seq_next(struct seq_file *seq, void *v, loff_t *pos)
static void bond_info_seq_stop(struct seq_file *seq, void *v)
__releases(&bond->lock)
__releases(&dev_base_lock)
__releases(RCU)
{
struct bonding *bond = seq->private;
read_unlock(&bond->lock);
read_unlock(&dev_base_lock);
rcu_read_unlock();
}
static void bond_info_show_master(struct seq_file *seq)