redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

staging: mt7621-gpio: rename MTK_MAX_BANK into MTK_BANK_CNT

Browse source 
There are 3 banks of gpios numbered '0' and '1' and '2'. So
the maximum bank number is "2". "3" is the count of banks.
In order to make the code looks and be correct on checking
max allowed gpio's id it makes sense to change the name of
this definition. Also there is another definitions which
start with the same prefix MKK_BANK_ of the new name so
having those with the same prefix makes all preprocessor
structure to be the same. This improves readability.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: NeilBrown <neil@brown.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Sergio Paracuellos 2018-05-25 18:54:47 +02:00 committed by Greg Kroah-Hartman
parent a5a5b283a2
commit e84ff3a22c
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/staging/mt7621-gpio/gpio-mt7621.c
View file

@ -14,7 +14,7 @@
#include <linux/interrupt.h>
#include <linux/platform_device.h>
#define MTK_MAX_BANK 3
#define MTK_BANK_CNT 3
#define MTK_BANK_WIDTH 32
enum mediatek_gpio_reg {
@ -43,7 +43,7 @@ struct mtk_data {
void __iomem *gpio_membase;
int gpio_irq;
struct irq_domain *gpio_irq_domain;
struct mtk_gc *gc_map[MTK_MAX_BANK];
struct mtk_gc *gc_map[MTK_BANK_CNT];
};
static inline struct mtk_gc
@ -156,7 +156,7 @@ mediatek_gpio_bank_probe(struct platform_device *pdev, struct device_node *bank)
struct mtk_gc *rg;
int ret;
if (!id || be32_to_cpu(*id) >= MTK_MAX_BANK)
if (!id || be32_to_cpu(*id) >= MTK_BANK_CNT)
return -EINVAL;
rg = devm_kzalloc(&pdev->dev, sizeof(struct mtk_gc), GFP_KERNEL);
@ -202,7 +202,7 @@ mediatek_gpio_irq_handler(struct irq_desc *desc)
struct mtk_data *gpio_data = irq_desc_get_handler_data(desc);
int i;
for (i = 0; i < MTK_MAX_BANK; i++) {
for (i = 0; i < MTK_BANK_CNT; i++) {
struct mtk_gc *rg = gpio_data->gc_map[i];
unsigned long pending;
int bit;
@ -345,7 +345,7 @@ mediatek_gpio_probe(struct platform_device *pdev)
gpio_data->gpio_irq = irq_of_parse_and_map(np, 0);
if (gpio_data->gpio_irq) {
gpio_data->gpio_irq_domain = irq_domain_add_linear(np,
MTK_MAX_BANK * MTK_BANK_WIDTH,
MTK_BANK_CNT * MTK_BANK_WIDTH,
&irq_domain_ops, gpio_data);
if (!gpio_data->gpio_irq_domain)
dev_err(&pdev->dev, "irq_domain_add_linear failed\n");