redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

[IPV4]: Make __devinet_sysctl_register return an error

Browse source 
Currently, this function is void, so failures in creating
sysctls for new/renamed devices are not reported to anywhere.

Fixing this is another complex (needed?) task, but this
return value is needed during the namespaces creation to
handle the case, when we failed to create "all" and "default"
entries.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Pavel Emelyanov 2007-12-16 13:30:07 -08:00 committed by David S. Miller
parent 8afd351c77
commit ea40b324d7
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
net/ipv4/devinet.c
View file

@ -1454,8 +1454,8 @@ static struct devinet_sysctl_table {
},
};
static void __devinet_sysctl_register(char *dev_name, int ctl_name,
struct ipv4_devconf *p)
static int __devinet_sysctl_register(struct net *net, char *dev_name,
int ctl_name, struct ipv4_devconf *p)
{
int i;
struct devinet_sysctl_table *t;
@ -1497,14 +1497,14 @@ static void __devinet_sysctl_register(char *dev_name, int ctl_name,
goto free_procname;
p->sysctl = t;
return;
return 0;
free_procname:
kfree(t->dev_name);
free:
kfree(t);
out:
return;
return -ENOBUFS;
}
static void __devinet_sysctl_unregister(struct ipv4_devconf *cnf)