redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

hwmon: fix error return code in abituguru_probe()

Browse source 
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Wei Yongjun 2013-05-13 14:01:43 +08:00 committed by Guenter Roeck
parent 159c8cddd9
commit ecacb0b17c
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
drivers/hwmon/abituguru.c
View file

@ -1414,14 +1414,18 @@ static int abituguru_probe(struct platform_device *pdev)
pr_info("found Abit uGuru\n"); pr_info("found Abit uGuru\n");
/* Register sysfs hooks */ /* Register sysfs hooks */
for (i = 0; i < sysfs_attr_i; i++) for (i = 0; i < sysfs_attr_i; i++) {
if (device_create_file(&pdev->dev, res = device_create_file(&pdev->dev,
&data->sysfs_attr[i].dev_attr)) &data->sysfs_attr[i].dev_attr);
if (res)
goto abituguru_probe_error; goto abituguru_probe_error;
for (i = 0; i < ARRAY_SIZE(abituguru_sysfs_attr); i++) }
if (device_create_file(&pdev->dev, for (i = 0; i < ARRAY_SIZE(abituguru_sysfs_attr); i++) {
&abituguru_sysfs_attr[i].dev_attr)) res = device_create_file(&pdev->dev,
&abituguru_sysfs_attr[i].dev_attr);
if (res)
goto abituguru_probe_error; goto abituguru_probe_error;
}
data->hwmon_dev = hwmon_device_register(&pdev->dev); data->hwmon_dev = hwmon_device_register(&pdev->dev);
if (!IS_ERR(data->hwmon_dev)) if (!IS_ERR(data->hwmon_dev))