redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

VSOCK: remove unnecessary ternary operator on return value 

Rather than assign the positive errno values to ret and then
checking if it is positive and flip the sign, just return the
errno value.

Detected by CoverityScan, CID#986649 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Jorgen Hansen <jhansen@vmware.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
zero-colors
Colin Ian King 2017-03-29 16:33:55 +01:00 committed by David S. Miller
parent 282ccf6efb
commit ed8bfd5c1c
1 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
net/vmw_vsock/vmci_transport.c
View File

@ -96,31 +96,23 @@ static int PROTOCOL_OVERRIDE = -1;
static s32 vmci_transport_error_to_vsock_error(s32 vmci_error)
{
int err;
switch (vmci_error) {
case VMCI_ERROR_NO_MEM:
err = ENOMEM;
break;
return -ENOMEM;
case VMCI_ERROR_DUPLICATE_ENTRY:
case VMCI_ERROR_ALREADY_EXISTS:
err = EADDRINUSE;
break;
return -EADDRINUSE;
case VMCI_ERROR_NO_ACCESS:
err = EPERM;
break;
return -EPERM;
case VMCI_ERROR_NO_RESOURCES:
err = ENOBUFS;
break;
return -ENOBUFS;
case VMCI_ERROR_INVALID_RESOURCE:
err = EHOSTUNREACH;
break;
return -EHOSTUNREACH;
case VMCI_ERROR_INVALID_ARGS:
default:
err = EINVAL;
break;
}
return err > 0 ? -err : err;
return -EINVAL;
}
static u32 vmci_transport_peer_rid(u32 peer_cid)