redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

net: xgene: avoid bogus maybe-uninitialized warning

Browse source 
In some configurations, gcc cannot trace the state of variables
across a spin_unlock() barrier, leading to a warning about
correct code:

xgene_enet_main.c: In function 'xgene_enet_start_xmit':
../../../phy/mdio-xgene.h:112:14: error: 'mss_index' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Here we can trivially move the assignment before that spin_unlock,
which reliably avoids the warning.

Fixes: e3978673f5 ("drivers: net: xgene: Fix MSS programming")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Arnd Bergmann 2016-12-08 22:57:05 +01:00 committed by David S. Miller
parent dece303fa3
commit f006b2c5df
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/net/ethernet/apm/xgene/xgene_enet_main.c
View file

@ -319,11 +319,11 @@ static int xgene_enet_setup_mss(struct net_device *ndev, u32 mss)
}
}
spin_unlock(&pdata->mss_lock);
/* No slots with ref_count = 0 available, return busy */
if (!mss_index_found)
return -EBUSY;
mss_index = -EBUSY;
spin_unlock(&pdata->mss_lock);
return mss_index;
}