redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

mwifiex: code rearrangement for better readability

Browse source 
Use negative check (if(!bss_desc)) and return failure
instead of failing a NULL check later in
mwifiex_check_network_compatibility() routine.

Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Amitkumar Karwar 2013-06-18 16:36:56 -07:00 committed by John W. Linville
parent 10d0b9030a
commit f2bbb07729
1 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
drivers/net/wireless/mwifiex/sta_ioctl.c
View file

@ -255,25 +255,24 @@ int mwifiex_bss_start(struct mwifiex_private *priv, struct cfg80211_bss *bss,
} }
if (priv->bss_mode == NL80211_IFTYPE_STATION) { if (priv->bss_mode == NL80211_IFTYPE_STATION) {
u8 config_bands;
/* Infra mode */ /* Infra mode */
ret = mwifiex_deauthenticate(priv, NULL); ret = mwifiex_deauthenticate(priv, NULL);
if (ret) if (ret)
goto done; goto done;
if (bss_desc) { if (!bss_desc)
u8 config_bands = 0; return -1;
if (mwifiex_band_to_radio_type((u8) bss_desc->bss_band) if (mwifiex_band_to_radio_type(bss_desc->bss_band) ==
== HostCmd_SCAN_RADIO_TYPE_BG) HostCmd_SCAN_RADIO_TYPE_BG)
config_bands = BAND_B | BAND_G | BAND_GN | config_bands = BAND_B | BAND_G | BAND_GN | BAND_GAC;
BAND_GAC;
else else
config_bands = BAND_A | BAND_AN | BAND_AAC; config_bands = BAND_A | BAND_AN | BAND_AAC;
if (!((config_bands | adapter->fw_bands) & if (!((config_bands | adapter->fw_bands) & ~adapter->fw_bands))
~adapter->fw_bands))
adapter->config_bands = config_bands; adapter->config_bands = config_bands;
}
ret = mwifiex_check_network_compatibility(priv, bss_desc); ret = mwifiex_check_network_compatibility(priv, bss_desc);
if (ret) if (ret)