redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

ubifs: fix bogus __mark_inode_dirty(I_DIRTY_SYNC | I_DIRTY_DATASYNC) call

Browse source 
I_DIRTY_DATASYNC is a strict superset of I_DIRTY_SYNC semantics, as
in mark dirty to be written out by fdatasync as well.  So dirtying
for both flags makes no sense.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Christoph Hellwig 2018-02-21 07:54:48 -08:00 committed by Al Viro
parent 2c2acd2d19
commit f35562549f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
fs/ubifs/file.c
View file

@ -1256,7 +1256,7 @@ static int do_setattr(struct ubifs_info *c, struct inode *inode,
* Inode length changed, so we have to make sure * Inode length changed, so we have to make sure
* @I_DIRTY_DATASYNC is set. * @I_DIRTY_DATASYNC is set.
*/ */
__mark_inode_dirty(inode, I_DIRTY_SYNC | I_DIRTY_DATASYNC); __mark_inode_dirty(inode, I_DIRTY_DATASYNC);
else else
mark_inode_dirty_sync(inode); mark_inode_dirty_sync(inode);
mutex_unlock(&ui->ui_mutex); mutex_unlock(&ui->ui_mutex);