redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

x86-32: Fix atomic64_inc_not_zero return value convention

Browse source 
atomic64_inc_not_zero must return 1 if it perfomed the add and 0 otherwise.
It was doing the opposite thing.

Signed-off-by: Luca Barbieri <luca@luca-barbieri.com>
LKML-Reference: <1267469749-11878-6-git-send-email-luca@luca-barbieri.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
This commit is contained in:
Luca Barbieri 2010-03-01 19:55:49 +01:00 committed by H. Peter Anvin
parent 25a304f277
commit f3e8313146
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
arch/x86/lib/atomic64_386_32.S
View file

@ -153,13 +153,12 @@ BEGIN inc_not_zero %esi
adcl $0, %edx
movl %eax, ($v)
movl %edx, 4($v)
xorl %eax, %eax
movl $1, %eax
2:
RETURN
3:
testl %edx, %edx
jne 1b
movl $1, %eax
jmp 2b
END_

3
arch/x86/lib/atomic64_cx8_32.S
View file

@ -212,14 +212,13 @@ ENTRY(atomic64_inc_not_zero_cx8)
cmpxchg8b (%esi)
jne 1b
xorl %eax, %eax
movl $1, %eax
3:
RESTORE ebx
ret
4:
testl %edx, %edx
jne 2b
movl $1, %eax
jmp 3b
CFI_ENDPROC
ENDPROC(atomic64_inc_not_zero_cx8)