redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

tools: usb: usbip: fix fd leak in case of 'fread' failure

Browse source 
Fix possible resource leak: fd

Signed-off-by: Elad Wexler <elad.wexler@gmail.com>
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Elad Wexler 2017-12-30 18:01:39 +02:00 committed by Greg Kroah-Hartman
parent cb48326493
commit f7a5d7b3ab
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tools/usb/usbip/libsrc/usbip_device_driver.c
View file

@ -92,7 +92,7 @@ int read_usb_vudc_device(struct udev_device *sdev, struct usbip_usb_device *dev)
return -1;
ret = fread((char *) &descr, sizeof(descr), 1, fd);
if (ret < 0)
return -1;
goto err;
fclose(fd);
copy_descr_attr(dev, &descr, bDeviceClass);
@ -124,6 +124,9 @@ int read_usb_vudc_device(struct udev_device *sdev, struct usbip_usb_device *dev)
name = udev_device_get_sysname(plat);
strncpy(dev->busid, name, SYSFS_BUS_ID_SIZE);
return 0;
err:
fclose(fd);
return -1;
}
static int is_my_device(struct udev_device *dev)