redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

powerpc/smp: Do not BUG_ON if invalid CPU during kick

Browse source 
During secondary start, we do not need to BUG_ON if an invalid CPU number
is passed. We already print an error if secondary cannot be started, so
just return an error instead.

Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Santosh Sivaraj 2017-06-27 12:30:05 +05:30 committed by Michael Ellerman
parent adeb8667ea
commit f8d0d5dc64
4 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
arch/powerpc/kernel/smp.c
View file

@ -112,7 +112,8 @@ int smp_generic_cpu_bootable(unsigned int nr)
#ifdef CONFIG_PPC64
int smp_generic_kick_cpu(int nr)
{
BUG_ON(nr < 0 || nr >= NR_CPUS);
if (nr < 0 || nr >= NR_CPUS)
return -EINVAL;
/*
* The processor is currently spinning, waiting for the

3
arch/powerpc/platforms/cell/smp.c
View file

@ -115,7 +115,8 @@ static void smp_cell_setup_cpu(int cpu)
static int smp_cell_kick_cpu(int nr)
{
BUG_ON(nr < 0 || nr >= NR_CPUS);
if (nr < 0 || nr >= NR_CPUS)
return -EINVAL;
if (!smp_startup_cpu(nr))
return -ENOENT;

3
arch/powerpc/platforms/powernv/smp.c
View file

@ -63,7 +63,8 @@ static int pnv_smp_kick_cpu(int nr)
long rc;
uint8_t status;
BUG_ON(nr < 0 || nr >= NR_CPUS);
if (nr < 0 || nr >= NR_CPUS)
return -EINVAL;
/*
* If we already started or OPAL is not supported, we just

3
arch/powerpc/platforms/pseries/smp.c
View file

@ -151,7 +151,8 @@ static void smp_setup_cpu(int cpu)
static int smp_pSeries_kick_cpu(int nr)
{
BUG_ON(nr < 0 || nr >= NR_CPUS);
if (nr < 0 || nr >= NR_CPUS)
return -EINVAL;
if (!smp_startup_cpu(nr))
return -ENOENT;