redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

OMAPFB: fix error handling in omapfb_find_best_mode()

Browse source 
omapfb_find_best_mode() doesn't check for the return value of kmalloc.
Fix this. This also removes the smatch warning:

drivers/video/omap2/omapfb/omapfb-main.c:2256 omapfb_find_best_mode()
error: potential null dereference 'specs'.  (kzalloc returns null)

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Tomi Valkeinen 2012-12-13 12:13:51 +02:00
parent 057eeaee68
commit fa0c5e7129
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/video/omap2/omapfb/omapfb-main.c
View file

@ -2241,12 +2241,18 @@ static int omapfb_find_best_mode(struct omap_dss_device *display,
len = 0x80 * 2;
edid = kmalloc(len, GFP_KERNEL);
if (edid == NULL)
return -ENOMEM;
r = display->driver->read_edid(display, edid, len);
if (r < 0)
goto err1;
specs = kzalloc(sizeof(*specs), GFP_KERNEL);
if (specs == NULL) {
r = -ENOMEM;
goto err1;
}
fb_edid_to_monspecs(edid, specs);