udf: Fix deadlock between writeback and udf_setsize()
commitf2e9535589
upstream. udf_setsize() called truncate_setsize() with i_data_sem held. Thus truncate_pagecache() called from truncate_setsize() could lock a page under i_data_sem which can deadlock as page lock ranks below i_data_sem - e. g. writeback can hold page lock and try to acquire i_data_sem to map a block. Fix the problem by moving truncate_setsize() calls from under i_data_sem. It is safe for us to change i_size without holding i_data_sem as all the places that depend on i_size being stable already hold inode_lock. Fixes:7e49b6f248
Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
9ebfb4fa3a
commit
fa67ac18ef
|
@ -1243,8 +1243,8 @@ int udf_setsize(struct inode *inode, loff_t newsize)
|
||||||
return err;
|
return err;
|
||||||
}
|
}
|
||||||
set_size:
|
set_size:
|
||||||
truncate_setsize(inode, newsize);
|
|
||||||
up_write(&iinfo->i_data_sem);
|
up_write(&iinfo->i_data_sem);
|
||||||
|
truncate_setsize(inode, newsize);
|
||||||
} else {
|
} else {
|
||||||
if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB) {
|
if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB) {
|
||||||
down_write(&iinfo->i_data_sem);
|
down_write(&iinfo->i_data_sem);
|
||||||
|
@ -1261,9 +1261,9 @@ set_size:
|
||||||
udf_get_block);
|
udf_get_block);
|
||||||
if (err)
|
if (err)
|
||||||
return err;
|
return err;
|
||||||
|
truncate_setsize(inode, newsize);
|
||||||
down_write(&iinfo->i_data_sem);
|
down_write(&iinfo->i_data_sem);
|
||||||
udf_clear_extent_cache(inode);
|
udf_clear_extent_cache(inode);
|
||||||
truncate_setsize(inode, newsize);
|
|
||||||
udf_truncate_extents(inode);
|
udf_truncate_extents(inode);
|
||||||
up_write(&iinfo->i_data_sem);
|
up_write(&iinfo->i_data_sem);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue