scsi: lpfc: make several unions static, fix non-ANSI prototype
There are several unions that are local to the source and do not need to be in global scope, so make them static. Also add in a missing void parameter to functions lpfc_nvme_cmd_template and lpfc_nvmet_cmd_template to clean up non-ANSI warning. Cleans up sparse warnings: drivers/scsi/lpfc/lpfc_nvme.c:68:19: warning: symbol 'lpfc_iread_cmd_template' was not declared. Should it be static? drivers/scsi/lpfc/lpfc_nvme.c:69:19: warning: symbol 'lpfc_iwrite_cmd_template' was not declared. Should it be static? drivers/scsi/lpfc/lpfc_nvme.c:70:19: warning: symbol 'lpfc_icmnd_cmd_template' was not declared. Should it be static? drivers/scsi/lpfc/lpfc_nvme.c:74:24: warning: non-ANSI function 'lpfc_tsend_cmd_template' was not declared. Should it be static? drivers/scsi/lpfc/lpfc_nvmet.c:78:19: warning: symbol 'lpfc_treceive_cmd_template' was not declared. Should it be static? drivers/scsi/lpfc/lpfc_nvmet.c:79:19: warning: symbol 'lpfc_trsp_cmd_template' was not declared. Should it be static? drivers/scsi/lpfc/lpfc_nvmet.c:83:25: warning: non-ANSI function declaration of function 'lpfc_nvmet_cmd_template' Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: James Smart <james.smart@broadcom.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
92eb506262
commit
fab2e466e9
|
@ -65,13 +65,13 @@ lpfc_release_nvme_buf(struct lpfc_hba *, struct lpfc_nvme_buf *);
|
|||
|
||||
static struct nvme_fc_port_template lpfc_nvme_template;
|
||||
|
||||
union lpfc_wqe128 lpfc_iread_cmd_template;
|
||||
union lpfc_wqe128 lpfc_iwrite_cmd_template;
|
||||
union lpfc_wqe128 lpfc_icmnd_cmd_template;
|
||||
static union lpfc_wqe128 lpfc_iread_cmd_template;
|
||||
static union lpfc_wqe128 lpfc_iwrite_cmd_template;
|
||||
static union lpfc_wqe128 lpfc_icmnd_cmd_template;
|
||||
|
||||
/* Setup WQE templates for NVME IOs */
|
||||
void
|
||||
lpfc_nvme_cmd_template()
|
||||
lpfc_nvme_cmd_template(void)
|
||||
{
|
||||
union lpfc_wqe128 *wqe;
|
||||
|
||||
|
|
|
@ -74,13 +74,13 @@ static int lpfc_nvmet_unsol_ls_issue_abort(struct lpfc_hba *,
|
|||
static void lpfc_nvmet_wqfull_flush(struct lpfc_hba *, struct lpfc_queue *,
|
||||
struct lpfc_nvmet_rcv_ctx *);
|
||||
|
||||
union lpfc_wqe128 lpfc_tsend_cmd_template;
|
||||
union lpfc_wqe128 lpfc_treceive_cmd_template;
|
||||
union lpfc_wqe128 lpfc_trsp_cmd_template;
|
||||
static union lpfc_wqe128 lpfc_tsend_cmd_template;
|
||||
static union lpfc_wqe128 lpfc_treceive_cmd_template;
|
||||
static union lpfc_wqe128 lpfc_trsp_cmd_template;
|
||||
|
||||
/* Setup WQE templates for NVME IOs */
|
||||
void
|
||||
lpfc_nvmet_cmd_template()
|
||||
lpfc_nvmet_cmd_template(void)
|
||||
{
|
||||
union lpfc_wqe128 *wqe;
|
||||
|
||||
|
|
Loading…
Reference in a new issue