redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

staging: rtl8723au: c2h_wk_callback(): Use GFP_KERNEL, and check return value 

It is safe to use GFP_KERNEL in a workqueue handler, and check the
return value. If the malloc fails, skip and try again.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
wifi-calibration
Jes Sorensen 2014-04-26 18:54:54 +02:00 committed by Greg Kroah-Hartman
parent 8282aeb63f
commit fbde412917
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/rtl8723au/core/rtw_cmd.c
View File

@ -1536,7 +1536,9 @@ static void c2h_wk_callback(struct work_struct *work)
/* This C2H event is read, clear it */
c2h_evt_clear23a(adapter);
} else if ((c2h_evt = (struct c2h_evt_hdr *)
kmalloc(16, GFP_ATOMIC))) {
kmalloc(16, GFP_KERNEL))) {
if (!c2h_evt)
continue;
/* This C2H event is not read, read & clear now */
if (c2h_evt_read23a(adapter, (u8*)c2h_evt) != _SUCCESS)
continue;