ALSA: line6: fix a crash in line6_hwdep_write()
The error checking here is messed up so we could end up dereferencing
-EFAULT.
Fixes: a16039cbf1
('ALSA: line6: Add hwdep interface to access the POD control messages')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
steinar/wifi_calib_4_9_kernel
parent
30c0702246
commit
fdd8218d7d
|
@ -604,8 +604,8 @@ line6_hwdep_write(struct snd_hwdep *hwdep, const char __user *data, long count,
|
||||||
}
|
}
|
||||||
|
|
||||||
data_copy = memdup_user(data, count);
|
data_copy = memdup_user(data, count);
|
||||||
if (IS_ERR(ERR_PTR))
|
if (IS_ERR(data_copy))
|
||||||
return -ENOMEM;
|
return PTR_ERR(data_copy);
|
||||||
|
|
||||||
rv = line6_send_raw_message(line6, data_copy, count);
|
rv = line6_send_raw_message(line6, data_copy, count);
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue