redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

xen/pvcalls: use WARN_ON(1) instead of __WARN() 

__WARN() is an internal helper that is only available on
some architectures, but causes a build error e.g. on ARM64
in some configurations:

drivers/xen/pvcalls-back.c: In function 'set_backend_state':
drivers/xen/pvcalls-back.c:1097:5: error: implicit declaration of function '__WARN' [-Werror=implicit-function-declaration]

Unfortunately, there is no equivalent of BUG() that takes no
arguments, but WARN_ON(1) is commonly used in other drivers
and works on all configurations.

Fixes: 7160378206b2 ("xen/pvcalls: xenbus state handling")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
zero-colors
Arnd Bergmann 2017-07-21 18:17:45 +02:00 committed by Boris Ostrovsky
parent a0e4fd14ba
commit fefcfb9935
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/xen/pvcalls-back.c
View File

@ -1098,7 +1098,7 @@ static void set_backend_state(struct xenbus_device *dev,
xenbus_switch_state(dev, XenbusStateClosing);
break;
default:
__WARN();
WARN_ON(1);
}
break;
case XenbusStateInitWait:
@ -1113,7 +1113,7 @@ static void set_backend_state(struct xenbus_device *dev,
xenbus_switch_state(dev, XenbusStateClosing);
break;
default:
__WARN();
WARN_ON(1);
}
break;
case XenbusStateConnected:
@ -1127,7 +1127,7 @@ static void set_backend_state(struct xenbus_device *dev,
xenbus_switch_state(dev, XenbusStateClosing);
break;
default:
__WARN();
WARN_ON(1);
}
break;
case XenbusStateClosing:
@ -1138,11 +1138,11 @@ static void set_backend_state(struct xenbus_device *dev,
xenbus_switch_state(dev, XenbusStateClosed);
break;
default:
__WARN();
WARN_ON(1);
}
break;
default:
__WARN();
WARN_ON(1);
}
}
}