From ffca5af954c202d47ef00ac46b90493eaa7fcde5 Mon Sep 17 00:00:00 2001 From: Steven King Date: Wed, 21 May 2014 16:00:31 -0700 Subject: [PATCH] m68knommu: setting the gpio data direction register to output doesn't dependent upon the value to output! Singed-off-by: Steven King Signed-off-by: Greg Ungerer --- arch/m68k/platform/coldfire/gpio.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/m68k/platform/coldfire/gpio.c b/arch/m68k/platform/coldfire/gpio.c index ab9ac4110877..e16888629285 100644 --- a/arch/m68k/platform/coldfire/gpio.c +++ b/arch/m68k/platform/coldfire/gpio.c @@ -76,10 +76,7 @@ int __mcfgpio_direction_output(unsigned gpio, int value) local_irq_save(flags); data = mcfgpio_read(__mcfgpio_pddr(gpio)); - if (value) - data |= mcfgpio_bit(gpio); - else - data &= mcfgpio_bit(gpio); + data |= mcfgpio_bit(gpio); mcfgpio_write(data, __mcfgpio_pddr(gpio)); /* now set the data to output */