Michalis Pappas
b268666f6b
staging: gdm72xx: Removed commented-out code
...
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 12:12:52 -07:00
Michalis Pappas
71fd11e1a0
staging: gdm72xx: Fix braces to conform with coding style
...
Fixes the following checkpatch.pl issue:
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 12:12:52 -07:00
Michalis Pappas
633c8a2fc9
staging: gdm72xx: Fix some camel-case variables
...
Fixes the following checkpatch.pl issue:
CHECK: Avoid CamelCase:
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 12:12:51 -07:00
Michalis Pappas
522c6ff211
staging: gdm72xx: Move logical continuation to previous line to conform to coding style
...
Fixes the following checkpatch.pl issue:
CHECK: Logical continuations should be on the previous line
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 12:12:51 -07:00
Michalis Pappas
baad5ee108
staging: gdm72xx: Modify a struct allocation to match coding standards
...
Fixes the following checkpatch.pl issue:
CHECK: Prefer kmalloc(sizeof(*entry)...) over kmalloc(sizeof(struct qos_entry_s)...)
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 12:12:51 -07:00
Michalis Pappas
917ab47f5a
staging: gdm72xx: Replace comparisons on jiffies values with wrap-safe functions
...
Fixes the following checkpatch.pl issue:
WARNING: Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 12:12:51 -07:00
Michalis Pappas
d0a3956fef
staging: gdm72xx: Remove unnecessary extern declarations from header files
...
Fixes the following checkpatch.pl issue:
CHECK: extern prototypes should be avoided in .h files
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 12:12:51 -07:00
Jes Sorensen
13b2beb342
staging: rtl8723au: Remove some unused ODM dynamic TX power functionality
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:36 -07:00
Jes Sorensen
a74aef2170
staging: rtl8723au: The DBG_IO code is all gone
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:36 -07:00
Jes Sorensen
a5daa10c38
staging: rtl8723au: Remove some leftover obsolete prototypes
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:36 -07:00
Jes Sorensen
68552a904c
staging: rtl8723au: Name port vs register access functions consistently
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:36 -07:00
Jes Sorensen
edbfd672ca
staging: rtl8723au: Call usb_write*() functions directly
...
This allows us to finally remove the ugly HAL interface for accessing
registers, and remove rtw_io.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:36 -07:00
Jes Sorensen
050abc4583
staging: rtl8723au: Call usb_read*() functions directly
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:35 -07:00
Jes Sorensen
1c1bc5f1dd
staging: rtl8723au: Call usb_read_interrupt() directly instead of via HAL layer
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:35 -07:00
Jes Sorensen
633475cf5e
staging: rtl8723au: Call usb_{read,write}_port() functions directly
...
Get rid of more HAL layer obfuscations
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:35 -07:00
Jes Sorensen
97ccc3a6be
staging: rtl8723au: Clean up usb_{read,write}_port() usage
...
Get rid of silly HAL convolution for calling usb_{read,write}_port()
functions.
Benefit from fact we just have one input address for read_port, so no
point storing this and carrying it around.
Pick pipe in the local function instead of based on dst/src address.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:35 -07:00
Jes Sorensen
4810ce070e
staging: rtl8723au: Use correct pipe type for USB interrupts
...
Use a correct pipe type when filling un interrupt urbs. This should
finally take care of the WARN() messages on the console when USB urbs
are submitted.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:34 -07:00
Jes Sorensen
af1853da17
staging: rtl8723au: Clean up mess of parenthesis abuse
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:34 -07:00
Jes Sorensen
428891a3cb
staging: rtl8723au: usb_ops_linux.h: Remove some unused #defines
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:34 -07:00
Jes Sorensen
2296fd2d92
staging: rtl8723au: Remove nasty wrappers used to hide wrong function types
...
Do not use #defines to hack around pre-history functions not matching
current APIs
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:34 -07:00
Jes Sorensen
a64ddc8d4e
staging: rtl8723au: Remove unused USB bulk related macros and variables
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:34 -07:00
Jes Sorensen
4631e5055e
staging: rtl8723au: Don't wrap calls to usb_control_msg()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:34 -07:00
Jes Sorensen
596f85adaa
staging: rtl8723au: Call usb_intf_{start,stop} directly
...
Rip out multiple layer of useless wrappers
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:33 -07:00
Jes Sorensen
c174eae6f7
staging: rtl8723au: Call rtl8723au_set_hw_type() directly
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:33 -07:00
Jes Sorensen
43aeefd925
staging: rtl8723au: Remove unused usb_suspend_sema
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:33 -07:00
Jes Sorensen
633dd914ca
staging: rtl8723au: Move last utility function from osdep_service.c to os_intfs.c
...
No point carrying a dedicated file just for this small helper, so move
it to os_intfs.c and get rid of osdep_service.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:33 -07:00
Jes Sorensen
e6ac6eb2ae
staging: rtl8723au: os_intfs.c: Various cosmetic cleanups
...
In addition skb->priorty is a u32, so make rtw_classify8021d return a
u32 to match.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:33 -07:00
Jes Sorensen
eb269884cf
staging: rtl8723au: os_dep/usb_ops_linux.c: More bad parenthesis cleanup
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:32 -07:00
Jes Sorensen
7438ccb936
staging: rtl8723au: hal/usb_ops_linux.c: Various cleanups
...
Reduce excessive parenthesis usage, remove unnecessary null
initialization of variables, and some bad formatting.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:32 -07:00
Jes Sorensen
9b00959fca
staging: rtl8723au: odm_precomp.h: Remove unused #define TEST_FALG__
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:32 -07:00
Jes Sorensen
18bd6df23d
staging: rtl8723au: hal_com.c: Fix one case of returning status in an s32
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:32 -07:00
Jes Sorensen
95d412d830
staging: rtl8723au: rtl8723a_cmd.c: Fix up bad return types
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:32 -07:00
Jes Sorensen
a5681f99b4
staging: rtl8723au: rtl8723a_hal_init.c: Fix more messy return type abuse
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:31 -07:00
Jes Sorensen
c691ec3373
staging: rtl8723au: rtl8723a_phycfg.c: Use int for error return codes
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:31 -07:00
Jes Sorensen
5c195cc27b
staging: rtl8723au: rtl8723au_xmit.c: Fixup messy return type usage
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:31 -07:00
Jes Sorensen
24ed8e4575
staging: rtl8723au: rtl8723au_xmit_tasklet(): Remove unnecessary variable init
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:31 -07:00
Jes Sorensen
e04cd3f5ed
staging: rtl8723au: usb_halinit.c: Another u8 error code case
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:31 -07:00
Jes Sorensen
86c3e3f11e
staging: rtl8723au: usb_intf.c: Fixup yet another round of u8 abuse for error type
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:31 -07:00
Jes Sorensen
9e2d06661a
staging: rtl8723au: os_intfs.c: Fixup more u8/uint abuse for error return codes
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:30 -07:00
Jes Sorensen
16b9632da2
staging: rtl8732au: ioctl_cfg80211.c: Fix another case of u8 abuse for error return
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:30 -07:00
Jes Sorensen
8fd873d93d
staging: rtl8723au: rtw_xmit.c: Be consistent in using int for error return type
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:30 -07:00
Jes Sorensen
f6fe0a414b
staging: rtl8723au: rtw_wlan_util.c: Fix up random mixing of bool vs int
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:30 -07:00
Jes Sorensen
95ddd22553
staging: rtl8723au: rtw_sta_mgt.c: Clean up messy usage of return types
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:30 -07:00
Jes Sorensen
75f3f03956
staging: rtl8723au: rtw_security.c: Clean up mess of error return code types
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:29 -07:00
Jes Sorensen
6963248033
staging: rtl8723au: decryptor() use int to store error codes
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:29 -07:00
Jes Sorensen
d5789247bb
staging: rtl8723au: Don't return true/false in unsigned int
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:29 -07:00
Jes Sorensen
f66e05d8fc
staging: rtl8723au: rtw_mlme_ext.c: Use int to return error codes
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:29 -07:00
Jes Sorensen
7e761c5a2a
staging: rtl8723au: rtw_ioctl_set.c: Fix up messy error code handling
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:29 -07:00
Jes Sorensen
43eeb8ee53
staging: rtl8723au: Remove unused usb_read_mem/usb_write_mem stubs
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:28 -07:00
Jes Sorensen
ad899b1219
staging: rtl8723au: Clean up error codes in IO functions
...
This also fixes up another messy case assuming _FAIL == false and
true == _SUCCESS
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:28 -07:00