1
0
Fork 0
remarkable-linux/fs/overlayfs
Miklos Szeredi 2cadb57dff ovl: fix permission checking for setattr
[ Upstream commit acff81ec2c ]

[Al Viro] The bug is in being too enthusiastic about optimizing ->setattr()
away - instead of "copy verbatim with metadata" + "chmod/chown/utimes"
(with the former being always safe and the latter failing in case of
insufficient permissions) it tries to combine these two.  Note that copyup
itself will have to do ->setattr() anyway; _that_ is where the elevated
capabilities are right.  Having these two ->setattr() (one to set verbatim
copy of metadata, another to do what overlayfs ->setattr() had been asked
to do in the first place) combined is where it breaks.

Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Cc: <stable@vger.kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
2016-04-13 17:14:29 -04:00
..
Kconfig ovl: rename filesystem type to "overlay" 2014-11-20 16:39:59 +01:00
Makefile ovl: rename filesystem type to "overlay" 2014-11-20 16:39:59 +01:00
copy_up.c ovl: use a minimal buffer in ovl_copy_xattr 2016-02-01 10:39:24 -05:00
dir.c ovl: ignore lower entries when checking purity of non-directory entries 2016-03-22 11:10:27 -04:00
inode.c ovl: fix permission checking for setattr 2016-04-13 17:14:29 -04:00
overlayfs.h overlayfs: Make f_path always point to the overlay and f_inode to the underlay 2015-10-22 14:43:26 -07:00
readdir.c ovl: check dentry positiveness in ovl_cleanup_whiteouts() 2016-02-01 11:37:35 -05:00
super.c ovl: ignore lower entries when checking purity of non-directory entries 2016-03-22 11:10:27 -04:00