1
0
Fork 0
remarkable-linux/drivers/media/i2c
Akinobu Mita daefaacc6e media: soc_camera: ov772x: correct setting of banding filter
[ Upstream commit 22216ec41e ]

The banding filter ON/OFF is controlled via bit 5 of COM8 register.  It
is attempted to be enabled in ov772x_set_params() by the following line.

	ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, 1);

But this unexpectedly results disabling the banding filter, because the
mask and set bits are exclusive.

On the other hand, ov772x_s_ctrl() correctly sets the bit by:

	ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, BNDF_ON_OFF);

The same fix was already applied to non-soc_camera version of ov772x
driver in the commit commit a024ee14cd ("media: ov772x: correct setting
of banding filter")

Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-10-03 17:00:50 -07:00
..
adv748x media: i2c: adv748x: fix HDMI field heights 2018-05-25 16:17:57 +02:00
cx25840 media: cx25840: Use subdev host data for PLL override 2018-07-11 16:29:21 +02:00
et8ek8 media: et8ek8: Decrease stack usage 2017-08-20 08:33:46 -04:00
m5mols media: i2c: m5mols: fix spelling mistake: "Machanics" -> "Mechanics" 2017-07-19 15:00:31 -04:00
s5c73m3 media: Convert to using %pOF instead of full_name 2017-08-20 08:20:20 -04:00
smiapp media: smiapp: fix timeout checking in smiapp_read_nvm 2018-08-03 07:50:33 +02:00
soc_camera media: soc_camera: ov772x: correct setting of banding filter 2018-10-03 17:00:50 -07:00
Kconfig media: ov13858: Select V4L2_FWNODE 2018-02-25 11:07:55 +01:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ad5820.c [media] ad5820: unregister async sub-device 2017-06-08 12:34:17 -03:00
ad9389b.c media: ad9389b: constify i2c_device_id 2017-08-26 08:42:12 -04:00
adp1653.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
adv7170.c [media] adv7170: drop redundant ret local 2017-01-30 15:47:05 -02:00
adv7175.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
adv7180.c media: adv7180: add missing adv7180cp, adv7180st i2c device IDs 2017-07-20 06:54:04 -04:00
adv7183.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
adv7183_regs.h scripts/spelling.txt: add "swithc" pattern and fix typo instances 2017-02-27 18:43:46 -08:00
adv7343.c [media] include/media: split I2C headers from V4L2 core 2015-11-17 06:57:11 -02:00
adv7343_regs.h [media] drivers: media: i2c: adv7343_regs.h: Fix typo in #ifndef 2014-09-21 20:12:13 -03:00
adv7393.c [media] media/i2c: Delete owner assignment 2016-09-06 16:21:24 -03:00
adv7393_regs.h
adv7511.c media: adv7511: constify i2c_device_id 2017-08-26 08:42:28 -04:00
adv7604.c media: adv7604: Prevent out of bounds access 2017-08-09 10:35:15 -04:00
adv7842.c media: adv7842: constify i2c_device_id 2017-08-26 08:42:43 -04:00
ak881x.c [media] drivers: media: i2c: ak881x: constify v4l2_subdev_* structures 2017-02-03 09:33:55 -02:00
aptina-pll.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
aptina-pll.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
as3645a.c [media] as3645a: Join string literals back 2017-06-20 08:18:12 -03:00
bt819.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
bt856.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
bt866.c Replace <asm/uaccess.h> with <linux/uaccess.h> globally 2016-12-24 11:46:01 -08:00
cs53l32a.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
cs3308.c [media] media/i2c: Delete owner assignment 2016-09-06 16:21:24 -03:00
cs5345.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
dw9714.c media: dw9714: Remove ACPI match tables, convert to use probe_new 2017-08-26 13:41:16 -04:00
ir-kbd-i2c.c media: rc: rename RC_TYPE_* to RC_PROTO_* and RC_BIT_* to RC_PROTO_BIT_* 2017-08-20 10:02:48 -04:00
ks0127.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
ks0127.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
lm3560.c [media] media framework: rename pads init function to media_entity_pads_init() 2016-01-11 12:19:03 -02:00
lm3646.c [media] media framework: rename pads init function to media_entity_pads_init() 2016-01-11 12:19:03 -02:00
m52790.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
max2175.c media: max2175: Propagate the real error on devm_clk_get() failure 2017-08-27 18:14:11 -04:00
max2175.h [media] media: i2c: max2175: Add MAX2175 support 2017-06-20 07:02:43 -03:00
ml86v7667.c [media] drivers: media: i2c: ml86v7667: constify v4l2_subdev_* structures 2017-02-03 09:34:43 -02:00
msp3400-driver.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
msp3400-driver.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
msp3400-kthreads.c [media] media drivers: annotate fall-through 2017-05-19 07:10:03 -03:00
mt9m032.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mt9m111.c media: mt9m111: constify video_subdev structures 2017-08-20 08:32:31 -04:00
mt9p031.c [media] drivers: media: i2c: constify v4l2_subdev_* structures 2017-02-03 09:23:19 -02:00
mt9t001.c media: v4l: mt9t001: constify video_subdev structures 2017-08-20 08:32:00 -04:00
mt9v011.c [media] mt9v011: add media controller support 2016-02-01 07:29:14 -02:00
mt9v032.c [media] v4l: Switch from V4L2 OF not V4L2 fwnode API 2017-06-06 09:58:16 -03:00
noon010pc30.c [media] drivers: media: i2c: constify v4l2_subdev_* structures 2017-02-03 09:23:19 -02:00
ov2640.c [media] ov2640: print error if devm_*_optional*() fails 2017-04-25 07:08:21 -03:00
ov2659.c [media] v4l: Switch from V4L2 OF not V4L2 fwnode API 2017-06-06 09:58:16 -03:00
ov5640.c media: ov5640: Remove unneeded gpiod NULL check 2017-07-26 08:41:57 -04:00
ov5645.c media: ov5645: Supported external clock is 24MHz 2018-09-26 08:38:00 +02:00
ov5647.c [media] v4l: Switch from V4L2 OF not V4L2 fwnode API 2017-06-06 09:58:16 -03:00
ov5670.c media: ov5670: Limit vblank to permissible range 2017-08-20 08:34:30 -04:00
ov6650.c media: ov6650: convert to standalone v4l2 subdevice 2017-07-18 12:14:31 -03:00
ov7640.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
ov7670.c media: ov7670: Check the return value from clk_prepare_enable() 2017-08-08 06:24:58 -04:00
ov9650.c media: ov9655: fix missing mutex_destroy() 2017-08-08 06:31:47 -04:00
ov13858.c media: ov13858: Limit vblank to permissible range 2017-08-20 08:35:11 -04:00
s5k4ecgx.c [media] media/i2c: Delete owner assignment 2016-09-06 16:21:24 -03:00
s5k5baf.c media: Convert to using %pOF instead of full_name 2017-08-20 08:20:20 -04:00
s5k6a3.c [media] drivers: media: i2c: constify v4l2_subdev_* structures 2017-02-03 09:23:19 -02:00
s5k6aa.c media: s5k6aa: describe some function parameters 2018-02-25 11:07:55 +01:00
saa711x_regs.h [media] saa7115: Implement i2c_board_info.platform_data 2013-08-18 08:27:07 -03:00
saa717x.c media: media/i2c/saa717x: fix spelling mistake: "implementd" -> "implemented" 2017-07-19 15:00:57 -04:00
saa6588.c Replace <asm/uaccess.h> with <linux/uaccess.h> globally 2016-12-24 11:46:01 -08:00
saa6752hs.c [media] i2c: Drop owner assignment from i2c_driver 2015-08-11 13:00:15 -03:00
saa7110.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
saa7115.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
saa7127.c media: saa7127: constify i2c_device_id 2017-08-26 08:42:57 -04:00
saa7185.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
smiapp-pll.c [media] smiapp-pll: Don't complain aloud about failing PLL calculation 2016-10-21 15:15:06 -02:00
smiapp-pll.h [media] smiapp-pll: include linux/device.h in smiapp-pll.c, not in smiapp-pll.h 2014-12-23 11:29:01 -02:00
sony-btf-mpx.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
sr030pc30.c [media] include/media: split I2C headers from V4L2 core 2015-11-17 06:57:11 -02:00
tc358743.c media: tc358743: constify i2c_device_id 2017-08-26 08:43:27 -04:00
tc358743_regs.h [media] tc358743: Disable HDCP with "manual HDCP authentication" bit 2017-02-03 11:16:02 -02:00
tda7432.c [media] i2c: Drop owner assignment from i2c_driver 2015-08-11 13:00:15 -03:00
tda9840.c [media] i2c: Drop owner assignment from i2c_driver 2015-08-11 13:00:15 -03:00
tea6415c.c [media] i2c: Drop owner assignment from i2c_driver 2015-08-11 13:00:15 -03:00
tea6415c.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
tea6420.c [media] i2c: Drop owner assignment from i2c_driver 2015-08-11 13:00:15 -03:00
tea6420.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ths7303.c [media] media: i2c: ths7303: remove redundant assignment on bt 2016-05-07 11:47:12 -03:00
ths8200.c media: ths8200: constify i2c_device_id 2017-08-26 08:43:40 -04:00
ths8200_regs.h [media] media: i2c: ths8200: driver for TI video encoder 2013-06-17 09:52:31 -03:00
tlv320aic23b.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tvaudio.c [media] tvaudio: mark printk continuation lines as such 2016-10-21 08:51:29 -02:00
tvp514x.c [media] v4l: Switch from V4L2 OF not V4L2 fwnode API 2017-06-06 09:58:16 -03:00
tvp514x_regs.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tvp5150.c media: Revert "[media] tvp5150: fix pad format frame height" 2018-09-09 19:55:53 +02:00
tvp5150_reg.h [media] v4l: tvp5150: Fix comment regarding output pin muxing 2016-12-21 07:31:49 -02:00
tvp7002.c [media] v4l: Switch from V4L2 OF not V4L2 fwnode API 2017-06-06 09:58:16 -03:00
tvp7002_reg.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tw2804.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tw9903.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tw9906.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
uda1342.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
upd64031a.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
upd64083.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
vp27smpx.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
vpx3220.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
vs6624.c media: vs6624: constify vs6624_default_fmt 2017-08-09 11:19:20 -04:00
vs6624_regs.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
wm8739.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
wm8775.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00