1
0
Fork 0
remarkable-linux/drivers/s390/crypto
Harald Freudenberger 82b90de5b1 s390/zcrypt: Fix wrong comparison leading to strange load balancing
[ Upstream commit 0b08826726 ]

The function to decide if one zcrypt queue is better than
another one compared two pointers instead of comparing the
values where the pointers refer to. So within the same
zcrypt card when load of each queue was equal just one queue
was used. This effect only appears on relatively lite load,
typically with one thread applications.

This patch fixes the wrong comparison and now the counters
show that requests are balanced equally over all available
queues within the cards.

There is no performance improvement coming with this fix.
As long as the queue depth for an APQN queue is not touched,
processing is not faster when requests are spread over
queues within the same card hardware. So this fix only
beautifies the lszcrypt counter printouts.

Signed-off-by: Harald Freudenberger <freude@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-02-03 17:38:59 +01:00
..
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ap_asm.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ap_bus.c s390/zcrypt: externalize AP config info query 2017-09-06 09:24:42 +02:00
ap_bus.h s390/zcrypt: externalize AP config info query 2017-09-06 09:24:42 +02:00
ap_card.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ap_debug.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ap_queue.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
pkey_api.c s390/pkey: add missing __user annotations 2017-06-12 16:25:56 +02:00
zcrypt_api.c s390/zcrypt: Fix wrong comparison leading to strange load balancing 2018-02-03 17:38:59 +01:00
zcrypt_api.h s390/zcrypt: export additional symbols 2017-02-23 10:06:40 +01:00
zcrypt_card.c s390/zcrypt_card: constify attribute_group structures. 2017-07-26 08:25:17 +02:00
zcrypt_cca_key.h s390/zcrypt: remove unused function zcrypt_type6_mex_key_de() 2017-06-12 16:25:57 +02:00
zcrypt_cex2a.c Replace <asm/uaccess.h> with <linux/uaccess.h> globally 2016-12-24 11:46:01 -08:00
zcrypt_cex2a.h s390/comments: unify copyright messages and remove file names 2012-07-20 11:15:04 +02:00
zcrypt_cex4.c s390/zcrypt: add multi domain support 2016-12-14 16:33:38 +01:00
zcrypt_cex4.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
zcrypt_debug.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
zcrypt_error.h s390/zcrypt: Rework debug feature invocations. 2016-12-14 16:33:39 +01:00
zcrypt_msgtype6.c s390/zcrypt: make CPRBX const 2017-08-29 16:31:25 +02:00
zcrypt_msgtype6.h s390/zcrypt: add multi domain support 2016-12-14 16:33:38 +01:00
zcrypt_msgtype50.c s390/zcrypt: Rework debug feature invocations. 2016-12-14 16:33:39 +01:00
zcrypt_msgtype50.h s390/zcrypt: Introduce workload balancing 2016-12-14 16:33:38 +01:00
zcrypt_pcixcc.c Replace <asm/uaccess.h> with <linux/uaccess.h> globally 2016-12-24 11:46:01 -08:00
zcrypt_pcixcc.h s390/zcrypt: Separate msgtype implementation from card modules. 2012-09-26 15:44:55 +02:00
zcrypt_queue.c s390/zcrypt_queue: constify attribute_group structures. 2017-07-26 08:25:16 +02:00