1
0
Fork 0
remarkable-linux/drivers/vme/bridges
Augusto Mecking Caringi c8a6a09c1c vme: Fix wrong pointer utilization in ca91cx42_slave_get
In ca91cx42_slave_get function, the value pointed by vme_base pointer is
set through:

*vme_base = ioread32(bridge->base + CA91CX42_VSI_BS[i]);

So it must be dereferenced to be used in calculation of pci_base:

*pci_base = (dma_addr_t)*vme_base + pci_offset;

This bug was caught thanks to the following gcc warning:

drivers/vme/bridges/vme_ca91cx42.c: In function ‘ca91cx42_slave_get’:
drivers/vme/bridges/vme_ca91cx42.c:467:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
*pci_base = (dma_addr_t)vme_base + pci_offset;

Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>
Acked-By: Martyn Welch <martyn@welchs.me.uk>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-01-11 10:42:16 +01:00
..
Kconfig vme: Adding Fake VME driver 2016-08-31 13:21:12 +02:00
Makefile vme: Adding Fake VME driver 2016-08-31 13:21:12 +02:00
vme_ca91cx42.c vme: Fix wrong pointer utilization in ca91cx42_slave_get 2017-01-11 10:42:16 +01:00
vme_ca91cx42.h vme: change LM callback argument to void pointer 2016-08-31 13:20:15 +02:00
vme_fake.c vme: fake: remove unexpected unlock in fake_master_set() 2016-09-27 12:43:35 +02:00
vme_tsi148.c vme: Fix module autoload 2016-08-31 13:20:16 +02:00
vme_tsi148.h vme: change LM callback argument to void pointer 2016-08-31 13:20:15 +02:00