John Fastabend f0a8c1257f tls: possible hang when do_tcp_sendpages hits sndbuf is full case ... [ Upstream commit 67db7cd249 ] Currently, the lower protocols sk_write_space handler is not called if TLS is sending a scatterlist via tls_push_sg. However, normally tls_push_sg calls do_tcp_sendpage, which may be under memory pressure, that in turn may trigger a wait via sk_wait_event. Typically, this happens when the in-flight bytes exceed the sdnbuf size. In the normal case when enough ACKs are received sk_write_space() will be called and the sk_wait_event will be woken up allowing it to send more data and/or return to the user. But, in the TLS case because the sk_write_space() handler does not wake up the events the above send will wait until the sndtimeo is exceeded. By default this is MAX_SCHEDULE_TIMEOUT so it look like a hang to the user (especially this impatient user). To fix this pass the sk_write_space event to the lower layers sk_write_space event which in the TCP case will wake any pending events. I observed the above while integrating sockmap and ktls. It initially appeared as test_sockmap (modified to use ktls) occasionally hanging. To reliably reproduce this reduce the sndbuf size and stress the tls layer by sending many 1B sends. This results in every byte needing a header and each byte individually being sent to the crypto layer. Signed-off-by: John Fastabend <john.fastabend@gmail.com> Acked-by: Dave Watson <davejwatson@fb.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-10-03 17:00:58 -07:00
..
6lowpan	6lowpan: iphc: reset mac_header after decompress to fix panic	2018-10-03 17:00:47 -07:00
9p	net/9p: fix error path of p9_virtio_probe	2018-09-15 09:45:29 +02:00
802	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
8021q	net: fix use-after-free in GRO with ESP	2018-07-22 14:28:44 +02:00
appletalk	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
atm	atm: Preserve value of skb->truesize when accounting to vcc	2018-07-22 14:28:43 +02:00
ax25	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
batman-adv	batman-adv: Fix multicast TT issues with bogus ROAM flags	2018-08-24 13:09:05 +02:00
bluetooth	Bluetooth: Use lock_sock_nested in bt_accept_enqueue	2018-09-26 08:38:09 +02:00
bpf	bpf: Align packet data properly in program testing framework.	2017-05-02 11:46:28 -04:00
bridge	netfilter: ebtables: reject non-bridge targets	2018-07-22 14:28:49 +02:00
caif	net: caif: Add a missing rcu_read_unlock() in caif_flow_cb	2018-09-05 09:26:27 +02:00
can	can: af_can: canfd_rcv(): replace WARN_ONCE by pr_warn_once	2018-01-23 19:58:17 +01:00
ceph	libceph, ceph: avoid memory leak when specifying same option several times	2018-05-30 07:52:04 +02:00
core	neighbour: confirm neigh entries when ARP packet is received	2018-09-29 03:06:01 -07:00
dcb	net: dcb: For wild-card lookups, use priority -1, not 0	2018-09-19 22:43:43 +02:00
dccp	dccp: fix undefined behavior with 'cwnd' shift in ccid2_cwnd_restart()	2018-08-22 07:46:08 +02:00
decnet	dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock	2018-02-25 11:07:52 +01:00
dns_resolver	KEYS: DNS: fix parsing multiple options	2018-07-22 14:28:49 +02:00
dsa	net: dsa: Do not suspend/resume closed slave_dev	2018-08-06 16:20:48 +02:00
ethernet	networking: make skb_push & __skb_push return void pointers	2017-06-16 11:48:40 -04:00
hsr	net/hsr: Check skb_put_padto() return value	2017-08-22 13:40:23 -07:00
ieee802154	inet: frags: fix ip6frag_low_thresh boundary	2018-09-19 22:43:47 +02:00
ife	net: sched: ife: check on metadata length	2018-04-29 11:33:13 +02:00
ipv4	udp4: fix IP_CMSG_CHECKSUM for connected sockets	2018-09-29 03:06:00 -07:00
ipv6	udp6: add missing checks on edumux packet processing	2018-09-29 03:06:01 -07:00
ipx	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
iucv	net/iucv: Free memory obtained by kzalloc	2018-03-31 18:10:41 +02:00
kcm	kcm: Fix use-after-free caused by clonned sockets	2018-06-11 22:49:19 +02:00
key	af_key: Always verify length of provided sadb_key	2018-06-16 09:45:14 +02:00
l2tp	l2tp: use sk_dst_check() to avoid race on sk->sk_dst_cache	2018-08-22 07:46:08 +02:00
l3mdev	…
lapb	net, lapb: convert lapb_cb.refcnt from atomic_t to refcount_t	2017-07-04 22:35:16 +01:00
llc	llc: use refcount_inc_not_zero() for llc_sap_find()	2018-08-22 07:46:08 +02:00
mac80211	mac80211: restrict delayed tailroom needed decrement	2018-09-26 08:38:03 +02:00
mac802154	net: mac802154: tx: expand tailroom if necessary	2018-09-09 19:55:52 +02:00
mpls	mpls, nospec: Sanitize array index in mpls_label_ok()	2018-02-22 15:42:28 +01:00
ncsi	net/ncsi: Fix length of GVI response packet	2017-10-21 01:56:38 +01:00
netfilter	netfilter: fix memory leaks on netlink_dump_start error	2018-09-15 09:45:28 +02:00
netlabel	netlabel: If PF_INET6, check sk_buff ip header version	2018-05-30 07:52:40 +02:00
netlink	netlink: Don't shift on 64 for ngroups	2018-08-09 12:16:38 +02:00
netrom	net, netrom: convert nr_node.refcount from atomic_t to refcount_t	2017-07-04 22:35:17 +01:00
nfc	NFC: Fix possible memory corruption when handling SHDLC I-Frame commands	2018-09-29 03:06:01 -07:00
nsh	nsh: set mac len based on inner packet	2018-07-22 14:28:49 +02:00
openvswitch	openvswitch: Don't swap table in nlattr_set() after OVS_ATTR_NESTED is found	2018-05-19 10:20:24 +02:00
packet	packet: refine ring v3 block size test to hold one frame	2018-08-24 13:09:22 +02:00
phonet	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
psample	MAINTAINERS: Update Yotam's E-mail	2017-11-01 12:19:03 +09:00
qrtr	net: qrtr: Broadcast messages only from control port	2018-08-24 13:09:13 +02:00
rds	rds: fix two RCU related problems	2018-09-26 08:37:57 +02:00
rfkill	rfkill: gpio: fix memory leak in probe error path	2018-05-16 10:10:26 +02:00
rose	…
rxrpc	rxrpc: Fix user call ID check in rxrpc_service_prealloc_one	2018-08-06 16:20:48 +02:00
sched	net/sched: act_sample: fix NULL dereference in the data path	2018-09-29 03:06:01 -07:00
sctp	sctp: hold transport before accessing its asoc in sctp_transport_get_next	2018-09-15 09:45:25 +02:00
smc	net/smc: no shutdown in state SMC_LISTEN	2018-08-24 13:09:22 +02:00
strparser	strparser: Remove early eaten to fix full tcp receive buffer stall	2018-07-22 14:28:47 +02:00
sunrpc	sunrpc: Don't use stack buffer with scatterlist	2018-09-15 09:45:26 +02:00
switchdev	net: switchdev: Remove bridge bypass support from switchdev	2017-08-07 14:48:48 -07:00
tipc	tipc: fix a missing rhashtable_walk_exit()	2018-09-15 09:45:25 +02:00
tls	tls: possible hang when do_tcp_sendpages hits sndbuf is full case	2018-10-03 17:00:58 -07:00
unix	License cleanup: add SPDX license identifiers to some files	2017-11-02 10:04:46 -07:00
vmw_vsock	vsock: split dwork to avoid reinitializations	2018-08-22 07:46:08 +02:00
wimax	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
wireless	nl80211: Add a missing break in parse_station_flags	2018-09-05 09:26:24 +02:00
x25	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm	xfrm: fix 'passing zero to ERR_PTR()' warning	2018-09-26 08:37:59 +02:00
Kconfig	net: Remove CONFIG_NETFILTER_DEBUG and _ASSERT() macros.	2017-09-04 13:25:20 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
compat.c	net: support compat 64-bit time in {s,g}etsockopt	2018-05-19 10:20:24 +02:00
socket.c	net: socket: fix potential spectre v1 gadget in socketcall	2018-08-06 16:20:48 +02:00
sysctl_net.c	sysctl: Remove dead register_sysctl_root	2017-04-16 23:42:49 -05:00