![Lv Zheng](/assets/img/avatar_default.png)
ACPICA commit 767ee53354e0c4b7e8e7c57c6dd7bf569f0d52bb There are issues related to the namespace/interpreter locks, which causes several ACPI functionalities not specification compliant. The lock issues were detectec when we were trying to fix the functionalities (please see Link # [1] for the details). What's the lock issues? Let's first look into the namespace/interpreter lock usages inside of the object evaluation and the table loading which are the key AML interpretion code paths: Table loading: acpi_ns_load_table L(Namespace) acpi_ns_parse_table acpi_ns_one_complete_parse(LOAD_PASS1/LOAD_PASS2) acpi_ds_load1_begion_op acpi_ds_load1_end_op acpi_ds_load2_begion_op acpi_ds_load2_end_op U(Namespace) Object evaluation: acpi_ns_evaluate L(Interpreter) acpi_ps_execute_method acpi_ds_exec_begin_op acpi_ds_exec_end_op U(Interpreter) acpi_ns_load_table L(Namespace) U(Namespace) acpi_ev_initialize_region L(Namespace) U(Namespace) address_space.Setup address_space.Handler acpi_os_wait_semaphore acpi_os_acquire_mutex acpi_os_sleep L(Interpreter) U(Interpreter) L(Interpreter) acpi_ex_resolve_node_to_value U(Interpreter) acpi_ns_check_return_value Where: 1. L(Interpreter) means acquire(MTX_INTERPRETER); 2. U(Interpreter) means release(MTX_INTERPRETER); 3. L(Namespace) means acquire(MTX_NAMESPACE); 4. U(Namespace) means release(MTX_NAMESPACE); We can see that acpi_ns_exec_module_code() (which invokes acpi_ns_evaluate) is implemented in a deferred way just in order to avoid to reacquire the namespace lock. This is in fact the root cause of many other ACPICA issues: 1. We now know for sure that the module code should be executed right in place by the Windows AML interpreter. So in the current design, if the region initializations/accesses or the table loadings (where the namespace surely should be locked again) happening during the table loading period, dead lock could happen because ACPICA never unlocks the namespace during the AML interpretion. 2. ACPICA interpreter just ensures that all static namespace nodes (named objects created during the acpi_load_tables()) are created (acpi_ns_lookup()) with the correct lock held, but doesn't ensure that the named objects created by the control method are created with the same correct lock held. It requires the control methods to be executed in a serial way after "loading a table", that's why ACPICA requires method auto serialization. This patch fixes these software design issues by extending interpreter enter/exit APIs to hold both interpreter/namespace locks to ensure the lock order correctness, so that we can get these code paths: Table loading: acpi_ns_load_table E(Interpreter) acpi_ns_parse_table acpi_ns_one_complete_parse acpi_ns_execute_table X(Interpreter) acpi_ns_load_table acpi_ev_initialize_region address_space.Setup address_space.Handler acpi_os_wait_semaphore acpi_os_acquire_mutex acpi_os_sleep E(Interpreter) X(Interpreter) Object evaluation: acpi_ns_evaluate E(Interpreter) acpi_ps_execute_method X(Interpreter) acpi_ns_load_table acpi_ev_initialize_region address_space.Setup address_space.Handler acpi_os_wait_semaphore acpi_os_acquire_mutex acpi_os_sleep E(Interpreter) X(Interpreter) Where: 1. E(Interpreter) means acquire(MTX_INTERPRETER, MTX_NAMESPACE); 2. X(Interpreter) means release(MTX_NAMESPACE, MTX_INTERPRETER); After this change, we can see: 1. All namespace nodes creations are locked by the namespace lock. 2. All namespace nodes referencing are locked with the same lock. 3. But we also can notice a defact that, all namespace nodes deletions could be affected by this change. As a consequence, acpi_ns_delete_namespace_subtree() may delete a static namespace node that is still referenced by the interpreter (for example, the parser scopes). Currently, we needn't worry about the last defact because in ACPICA, table unloading is not fully functioning, its design strictly relies on the fact that when the namespace deletion happens, either the AML table or the OSPMs should have been notified and thus either the AML table or the OSPMs shouldn't reference deletion-related namespace nodes during the namespace deletion. And this change still works with the above restrictions applied. While making this a-step-forward helps us to correct the wrong grammar to pull many things back to the correct rail. And pulling things back to the correct rail in return makes it possible for us to support fully functioning table unloading after doing many cleanups. While this patch is generated, all namespace locks are examined to ensure that they can meet either of the following pattens: 1. L(Namespace) U(Namespace) 2. E(Interpreter) X(Interpreter) 3. E(Interpreter) X(Interpreter) L(Namespace) U(Namespace) E(Interpreter) X(Interpreter) We ensure this by adding X(Interpreter)/E(Interpreter) or removing U(Namespace)/L(Namespace) for those currently are executed in the following order: E(Interpreter) L(Namespace) U(Namespace) X(Interpreter) And adding E(Interpreter)/X(Interpreter) for those currently are executed in the following order: X(Interpreter) E(Interpreter) Originally, the interpreter lock is held for the execution AML opcodes, the namespace lock is held for the named object creation AML opcodes. Since they are actually same in MS interpreter (can all be executed during the table loading), we can combine the 2 locks and tune the locking code better in this way. Lv Zheng. Link: https://bugzilla.kernel.org/show_bug.cgi?id=153541 # [1] Link: https://bugzilla.kernel.org/show_bug.cgi?id=121701 # [1] Link: https://bugs.acpica.org/show_bug.cgi?id=1323 Link: https://github.com/acpica/acpica/commit/767ee533 Reported-and-tested-by: Mika Westerberg <mika.westerberg@linux.intel.com> Reported-and-tested-by: Greg White <gwhite@kupulau.com> Reported-and-tested-by: Dutch Guy <lucht_piloot@gmx.net> Signed-off-by: Lv Zheng <lv.zheng@intel.com> Signed-off-by: Bob Moore <robert.moore@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
312 lines
9.4 KiB
C
312 lines
9.4 KiB
C
/******************************************************************************
|
|
*
|
|
* Module Name: nsparse - namespace interface to AML parser
|
|
*
|
|
*****************************************************************************/
|
|
|
|
/*
|
|
* Copyright (C) 2000 - 2016, Intel Corp.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions, and the following disclaimer,
|
|
* without modification.
|
|
* 2. Redistributions in binary form must reproduce at minimum a disclaimer
|
|
* substantially similar to the "NO WARRANTY" disclaimer below
|
|
* ("Disclaimer") and any redistribution must be conditioned upon
|
|
* including a substantially similar Disclaimer requirement for further
|
|
* binary redistribution.
|
|
* 3. Neither the names of the above-listed copyright holders nor the names
|
|
* of any contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* Alternatively, this software may be distributed under the terms of the
|
|
* GNU General Public License ("GPL") version 2 as published by the Free
|
|
* Software Foundation.
|
|
*
|
|
* NO WARRANTY
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* HOLDERS OR CONTRIBUTORS BE LIABLE FOR SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
|
|
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
|
|
* IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGES.
|
|
*/
|
|
|
|
#include <acpi/acpi.h>
|
|
#include "accommon.h"
|
|
#include "acnamesp.h"
|
|
#include "acparser.h"
|
|
#include "acdispat.h"
|
|
#include "actables.h"
|
|
#include "acinterp.h"
|
|
|
|
#define _COMPONENT ACPI_NAMESPACE
|
|
ACPI_MODULE_NAME("nsparse")
|
|
|
|
/*******************************************************************************
|
|
*
|
|
* FUNCTION: ns_execute_table
|
|
*
|
|
* PARAMETERS: table_desc - An ACPI table descriptor for table to parse
|
|
* start_node - Where to enter the table into the namespace
|
|
*
|
|
* RETURN: Status
|
|
*
|
|
* DESCRIPTION: Load ACPI/AML table by executing the entire table as a
|
|
* term_list.
|
|
*
|
|
******************************************************************************/
|
|
acpi_status
|
|
acpi_ns_execute_table(u32 table_index, struct acpi_namespace_node *start_node)
|
|
{
|
|
acpi_status status;
|
|
struct acpi_table_header *table;
|
|
acpi_owner_id owner_id;
|
|
struct acpi_evaluate_info *info = NULL;
|
|
u32 aml_length;
|
|
u8 *aml_start;
|
|
union acpi_operand_object *method_obj = NULL;
|
|
|
|
ACPI_FUNCTION_TRACE(ns_execute_table);
|
|
|
|
status = acpi_get_table_by_index(table_index, &table);
|
|
if (ACPI_FAILURE(status)) {
|
|
return_ACPI_STATUS(status);
|
|
}
|
|
|
|
/* Table must consist of at least a complete header */
|
|
|
|
if (table->length < sizeof(struct acpi_table_header)) {
|
|
return_ACPI_STATUS(AE_BAD_HEADER);
|
|
}
|
|
|
|
aml_start = (u8 *)table + sizeof(struct acpi_table_header);
|
|
aml_length = table->length - sizeof(struct acpi_table_header);
|
|
|
|
status = acpi_tb_get_owner_id(table_index, &owner_id);
|
|
if (ACPI_FAILURE(status)) {
|
|
return_ACPI_STATUS(status);
|
|
}
|
|
|
|
/* Create, initialize, and link a new temporary method object */
|
|
|
|
method_obj = acpi_ut_create_internal_object(ACPI_TYPE_METHOD);
|
|
if (!method_obj) {
|
|
return_ACPI_STATUS(AE_NO_MEMORY);
|
|
}
|
|
|
|
/* Allocate the evaluation information block */
|
|
|
|
info = ACPI_ALLOCATE_ZEROED(sizeof(struct acpi_evaluate_info));
|
|
if (!info) {
|
|
status = AE_NO_MEMORY;
|
|
goto cleanup;
|
|
}
|
|
|
|
ACPI_DEBUG_PRINT((ACPI_DB_PARSE,
|
|
"Create table code block: %p\n", method_obj));
|
|
|
|
method_obj->method.aml_start = aml_start;
|
|
method_obj->method.aml_length = aml_length;
|
|
method_obj->method.owner_id = owner_id;
|
|
method_obj->method.info_flags |= ACPI_METHOD_MODULE_LEVEL;
|
|
|
|
info->pass_number = ACPI_IMODE_EXECUTE;
|
|
info->node = start_node;
|
|
info->obj_desc = method_obj;
|
|
info->node_flags = info->node->flags;
|
|
info->full_pathname = acpi_ns_get_normalized_pathname(info->node, TRUE);
|
|
if (!info->full_pathname) {
|
|
status = AE_NO_MEMORY;
|
|
goto cleanup;
|
|
}
|
|
|
|
status = acpi_ps_execute_table(info);
|
|
|
|
cleanup:
|
|
if (info) {
|
|
ACPI_FREE(info->full_pathname);
|
|
info->full_pathname = NULL;
|
|
}
|
|
ACPI_FREE(info);
|
|
acpi_ut_remove_reference(method_obj);
|
|
return_ACPI_STATUS(status);
|
|
}
|
|
|
|
/*******************************************************************************
|
|
*
|
|
* FUNCTION: ns_one_complete_parse
|
|
*
|
|
* PARAMETERS: pass_number - 1 or 2
|
|
* table_desc - The table to be parsed.
|
|
*
|
|
* RETURN: Status
|
|
*
|
|
* DESCRIPTION: Perform one complete parse of an ACPI/AML table.
|
|
*
|
|
******************************************************************************/
|
|
|
|
acpi_status
|
|
acpi_ns_one_complete_parse(u32 pass_number,
|
|
u32 table_index,
|
|
struct acpi_namespace_node *start_node)
|
|
{
|
|
union acpi_parse_object *parse_root;
|
|
acpi_status status;
|
|
u32 aml_length;
|
|
u8 *aml_start;
|
|
struct acpi_walk_state *walk_state;
|
|
struct acpi_table_header *table;
|
|
acpi_owner_id owner_id;
|
|
|
|
ACPI_FUNCTION_TRACE(ns_one_complete_parse);
|
|
|
|
status = acpi_get_table_by_index(table_index, &table);
|
|
if (ACPI_FAILURE(status)) {
|
|
return_ACPI_STATUS(status);
|
|
}
|
|
|
|
/* Table must consist of at least a complete header */
|
|
|
|
if (table->length < sizeof(struct acpi_table_header)) {
|
|
return_ACPI_STATUS(AE_BAD_HEADER);
|
|
}
|
|
|
|
aml_start = (u8 *)table + sizeof(struct acpi_table_header);
|
|
aml_length = table->length - sizeof(struct acpi_table_header);
|
|
|
|
status = acpi_tb_get_owner_id(table_index, &owner_id);
|
|
if (ACPI_FAILURE(status)) {
|
|
return_ACPI_STATUS(status);
|
|
}
|
|
|
|
/* Create and init a Root Node */
|
|
|
|
parse_root = acpi_ps_create_scope_op(aml_start);
|
|
if (!parse_root) {
|
|
return_ACPI_STATUS(AE_NO_MEMORY);
|
|
}
|
|
|
|
/* Create and initialize a new walk state */
|
|
|
|
walk_state = acpi_ds_create_walk_state(owner_id, NULL, NULL, NULL);
|
|
if (!walk_state) {
|
|
acpi_ps_free_op(parse_root);
|
|
return_ACPI_STATUS(AE_NO_MEMORY);
|
|
}
|
|
|
|
status = acpi_ds_init_aml_walk(walk_state, parse_root, NULL,
|
|
aml_start, aml_length, NULL,
|
|
(u8)pass_number);
|
|
if (ACPI_FAILURE(status)) {
|
|
acpi_ds_delete_walk_state(walk_state);
|
|
goto cleanup;
|
|
}
|
|
|
|
/* Found OSDT table, enable the namespace override feature */
|
|
|
|
if (ACPI_COMPARE_NAME(table->signature, ACPI_SIG_OSDT) &&
|
|
pass_number == ACPI_IMODE_LOAD_PASS1) {
|
|
walk_state->namespace_override = TRUE;
|
|
}
|
|
|
|
/* start_node is the default location to load the table */
|
|
|
|
if (start_node && start_node != acpi_gbl_root_node) {
|
|
status =
|
|
acpi_ds_scope_stack_push(start_node, ACPI_TYPE_METHOD,
|
|
walk_state);
|
|
if (ACPI_FAILURE(status)) {
|
|
acpi_ds_delete_walk_state(walk_state);
|
|
goto cleanup;
|
|
}
|
|
}
|
|
|
|
/* Parse the AML */
|
|
|
|
ACPI_DEBUG_PRINT((ACPI_DB_PARSE,
|
|
"*PARSE* pass %u parse\n", pass_number));
|
|
acpi_ex_enter_interpreter();
|
|
status = acpi_ps_parse_aml(walk_state);
|
|
acpi_ex_exit_interpreter();
|
|
|
|
cleanup:
|
|
acpi_ps_delete_parse_tree(parse_root);
|
|
return_ACPI_STATUS(status);
|
|
}
|
|
|
|
/*******************************************************************************
|
|
*
|
|
* FUNCTION: acpi_ns_parse_table
|
|
*
|
|
* PARAMETERS: table_desc - An ACPI table descriptor for table to parse
|
|
* start_node - Where to enter the table into the namespace
|
|
*
|
|
* RETURN: Status
|
|
*
|
|
* DESCRIPTION: Parse AML within an ACPI table and return a tree of ops
|
|
*
|
|
******************************************************************************/
|
|
|
|
acpi_status
|
|
acpi_ns_parse_table(u32 table_index, struct acpi_namespace_node *start_node)
|
|
{
|
|
acpi_status status;
|
|
|
|
ACPI_FUNCTION_TRACE(ns_parse_table);
|
|
|
|
if (acpi_gbl_parse_table_as_term_list) {
|
|
ACPI_DEBUG_PRINT((ACPI_DB_PARSE, "**** Start load pass\n"));
|
|
|
|
status = acpi_ns_execute_table(table_index, start_node);
|
|
if (ACPI_FAILURE(status)) {
|
|
return_ACPI_STATUS(status);
|
|
}
|
|
} else {
|
|
/*
|
|
* AML Parse, pass 1
|
|
*
|
|
* In this pass, we load most of the namespace. Control methods
|
|
* are not parsed until later. A parse tree is not created.
|
|
* Instead, each Parser Op subtree is deleted when it is finished.
|
|
* This saves a great deal of memory, and allows a small cache of
|
|
* parse objects to service the entire parse. The second pass of
|
|
* the parse then performs another complete parse of the AML.
|
|
*/
|
|
ACPI_DEBUG_PRINT((ACPI_DB_PARSE, "**** Start pass 1\n"));
|
|
|
|
status = acpi_ns_one_complete_parse(ACPI_IMODE_LOAD_PASS1,
|
|
table_index, start_node);
|
|
if (ACPI_FAILURE(status)) {
|
|
return_ACPI_STATUS(status);
|
|
}
|
|
|
|
/*
|
|
* AML Parse, pass 2
|
|
*
|
|
* In this pass, we resolve forward references and other things
|
|
* that could not be completed during the first pass.
|
|
* Another complete parse of the AML is performed, but the
|
|
* overhead of this is compensated for by the fact that the
|
|
* parse objects are all cached.
|
|
*/
|
|
ACPI_DEBUG_PRINT((ACPI_DB_PARSE, "**** Start pass 2\n"));
|
|
status = acpi_ns_one_complete_parse(ACPI_IMODE_LOAD_PASS2,
|
|
table_index, start_node);
|
|
if (ACPI_FAILURE(status)) {
|
|
return_ACPI_STATUS(status);
|
|
}
|
|
}
|
|
|
|
return_ACPI_STATUS(status);
|
|
}
|