remarkable-linux/drivers/staging/most/hdm-dim2
Bhumika Goyal d983c59775 Staging: most: hdm-dim2: constify attribute_group structures
Check for attribute_group structures that are only passed as a second
argument to the functions sysfs_remove_group and sysfs_create_group. As
these arguments are constant so, attribute_group structures having this
property can also be made constant.
Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
expression e1,e2;
@@
(
sysfs_remove_group(e1,&i@p)
|
sysfs_create_group(e1,&i@p)
)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before:
   text	   data	    bss	    dec	    hex	filename
    509	    160	      0	    669	    29d
drivers/staging/most/hdm-dim2/dim2_sysfs.o

File size after:
   text	   data	    bss	    dec	    hex	filename
    565	     96	      0	    661	    295
drivers/staging/most/hdm-dim2/dim2_sysfs.o

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-02 17:24:00 +02:00
..
dim2_errors.h Staging: most: Remove __cplusplus check in header files 2016-03-28 07:30:36 -07:00
dim2_hal.c staging: most: hdm-dim2: monitor atx DBR space 2016-09-15 19:23:29 +02:00
dim2_hal.h staging: most: hdm-dim2: monitor atx DBR space 2016-09-15 19:23:29 +02:00
dim2_hdm.c staging: most: replace MOST_CH_ISOC_AVP with MOST_CH_ISOC 2016-09-22 11:54:47 +02:00
dim2_hdm.h staging: most: add __iomem for io_base and registers 2016-02-07 17:34:58 -08:00
dim2_reg.h staging: most: hdm-dim2: monitor atx DBR space 2016-09-15 19:23:29 +02:00
dim2_sysfs.c Staging: most: hdm-dim2: constify attribute_group structures 2016-10-02 17:24:00 +02:00
dim2_sysfs.h
Kconfig
Makefile