1e3aeae4ea
device_add() may fail, and all callers are supposed to check the
return value, but one new user in lightnvm doesn't:
drivers/lightnvm/sysfs.c: In function 'nvm_sysfs_register_dev':
drivers/lightnvm/sysfs.c:184:2: error: ignoring return value of 'device_add',
declared with attribute warn_unused_result [-Werror=unused-result]
This changes the caller to propagate any error codes, which avoids
the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 38c9e260b9f9 ("lightnvm: expose device geometry through sysfs")
Signed-off-by: Matias Bjørling <m@bjorling.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
36 lines
1.1 KiB
C
36 lines
1.1 KiB
C
/*
|
|
* Copyright (C) 2016 CNEX Labs. All rights reserved.
|
|
* Initial release: Matias Bjorling <matias@cnexlabs.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License version
|
|
* 2 as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; see the file COPYING. If not, write to
|
|
* the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139,
|
|
* USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LIGHTNVM_H
|
|
#define LIGHTNVM_H
|
|
|
|
#include <linux/lightnvm.h>
|
|
|
|
/* core -> sysfs.c */
|
|
int __must_check nvm_sysfs_register_dev(struct nvm_dev *);
|
|
void nvm_sysfs_unregister_dev(struct nvm_dev *);
|
|
int nvm_sysfs_register(void);
|
|
void nvm_sysfs_unregister(void);
|
|
|
|
/* sysfs > core */
|
|
void nvm_free(struct nvm_dev *);
|
|
|
|
#endif
|