8e2a2bfdb8
kasprintf relies on being able to replay the formatting and getting the same result (in particular, the same length). This will almost always work, but it is possible that the object pointed to by a %s or %p argument changed under us (so we might get truncated output). Add a somewhat paranoid sanity check and let's see if it ever triggers. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Cc: Al Viro <viro@ZenIV.linux.org.uk> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Joe Perches <joe@perches.com> Cc: Kees Cook <keescook@chromium.org> Cc: Maurizio Lombardi <mlombard@redhat.com> Cc: Tejun Heo <tj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
64 lines
1.4 KiB
C
64 lines
1.4 KiB
C
/*
|
|
* linux/lib/kasprintf.c
|
|
*
|
|
* Copyright (C) 1991, 1992 Linus Torvalds
|
|
*/
|
|
|
|
#include <stdarg.h>
|
|
#include <linux/export.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/types.h>
|
|
#include <linux/string.h>
|
|
|
|
/* Simplified asprintf. */
|
|
char *kvasprintf(gfp_t gfp, const char *fmt, va_list ap)
|
|
{
|
|
unsigned int first, second;
|
|
char *p;
|
|
va_list aq;
|
|
|
|
va_copy(aq, ap);
|
|
first = vsnprintf(NULL, 0, fmt, aq);
|
|
va_end(aq);
|
|
|
|
p = kmalloc_track_caller(first+1, gfp);
|
|
if (!p)
|
|
return NULL;
|
|
|
|
second = vsnprintf(p, first+1, fmt, ap);
|
|
WARN(first != second, "different return values (%u and %u) from vsnprintf(\"%s\", ...)",
|
|
first, second, fmt);
|
|
|
|
return p;
|
|
}
|
|
EXPORT_SYMBOL(kvasprintf);
|
|
|
|
/*
|
|
* If fmt contains no % (or is exactly %s), use kstrdup_const. If fmt
|
|
* (or the sole vararg) points to rodata, we will then save a memory
|
|
* allocation and string copy. In any case, the return value should be
|
|
* freed using kfree_const().
|
|
*/
|
|
const char *kvasprintf_const(gfp_t gfp, const char *fmt, va_list ap)
|
|
{
|
|
if (!strchr(fmt, '%'))
|
|
return kstrdup_const(fmt, gfp);
|
|
if (!strcmp(fmt, "%s"))
|
|
return kstrdup_const(va_arg(ap, const char*), gfp);
|
|
return kvasprintf(gfp, fmt, ap);
|
|
}
|
|
EXPORT_SYMBOL(kvasprintf_const);
|
|
|
|
char *kasprintf(gfp_t gfp, const char *fmt, ...)
|
|
{
|
|
va_list ap;
|
|
char *p;
|
|
|
|
va_start(ap, fmt);
|
|
p = kvasprintf(gfp, fmt, ap);
|
|
va_end(ap);
|
|
|
|
return p;
|
|
}
|
|
EXPORT_SYMBOL(kasprintf);
|